Page MenuHomePhabricator
Differential D5732

Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 14 2020, 22:50.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING245bf8cc7f0a: Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan
rABC245bf8cc7f0a: Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan
Summary

This is the first of two patches resulting from breaking the changes
to rpcwallet.cpp into smaller parts.

Partial backport of Core PR14796

Test Plan
mkdir master
mkdir patched

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

On the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rpcwallethelp.txt

Verify the changes in rpcwallethelp.txt.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

D5722diff:

rpcwallethelp.txt11 KBDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rpcwallethelp1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10222
Build 18269: Default Diff Build & Tests
Build 18268: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 14 2020, 22:50
Owners added a reviewer: Restricted Owners Package.Apr 14 2020, 22:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 14 2020, 22:50
nakihito planned changes to this revision.Apr 14 2020, 22:50
teamcity edited the summary of this revision. (Show Details)Apr 14 2020, 22:51

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 14 2020, 22:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito mentioned this in D5722: Finish passing the remainder of wallet/rpcwallet RPC argument descriptions to RPCHelpMan.Apr 14 2020, 22:53
nakihito edited the test plan for this revision. (Show Details)Apr 14 2020, 22:56
nakihito requested review of this revision.Apr 14 2020, 23:01
teamcity added a comment.Apr 14 2020, 23:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10222: Diff 18812.Apr 14 2020, 23:01
deadalnix accepted this revision.Apr 15 2020, 15:58
This revision is now accepted and ready to land.Apr 15 2020, 15:58
nakihito mentioned this in D5726: Complete PR14796 by cleaning up some old functions and names.Apr 15 2020, 20:38
nakihito added a child revision: D5726: Complete PR14796 by cleaning up some old functions and names.
Closed by commit rABC245bf8cc7f0a: Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan (authored by nakihito). · Explain WhyApr 15 2020, 20:39
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC245bf8cc7f0a: Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan.
nakihito mentioned this in rABC02ab89366a5a: Complete PR14796 by cleaning up some old functions and names.Apr 15 2020, 22:28
nakihito added a commit: rSTAGING245bf8cc7f0a: Start passing some wallet/rpcwallet RPC argument descriptions to RPCHelpMan.May 5 2020, 18:58
nakihito mentioned this in rSTAGING02ab89366a5a: Complete PR14796 by cleaning up some old functions and names.

Revision Contents
Changeset List

PathSize
src/
wallet/
712 lines

Diff 18812

View Options

src/wallet/rpcwallet.cpp

Loading...