Page MenuHomePhabricator
Differential D5811

Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists.
ClosedPublic
Actions

Authored by deadalnix on Apr 22 2020, 21:49.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGING77355596721c: Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists.
rABC77355596721c: Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists.
Summary

Currently we log a message indicating that a bitcoin.conf file is being used
even if one does not exists. This commit changes the logic to only display
this message if a config file exists and logs a separate message
if no config file exists. Additionally, a warning is now logged if the file
path passed in the -conf flag does not exist.

This is a backport of Core PR14057

Test Plan

Run bitcoind and check the output for

Config file: /home/deadalnix/.bitcoin/bitcoin.conf (not found, skipping)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14057
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10360
Build 18541: Default Diff Build & Tests
Build 18540: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 22 2020, 21:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2020, 21:49
teamcity edited the summary of this revision. (Show Details)Apr 22 2020, 21:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 22 2020, 21:50

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito accepted this revision.Apr 22 2020, 21:52
This revision is now accepted and ready to land.Apr 22 2020, 21:52
nakihito requested changes to this revision.Apr 22 2020, 21:54

QT test plan?

This revision now requires changes to proceed.Apr 22 2020, 21:54
teamcity added a comment.Apr 22 2020, 22:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10360: Diff 19043.Apr 22 2020, 22:01
deadalnix requested review of this revision.Apr 22 2020, 22:25

This does not touch Qt.

nakihito accepted this revision.Apr 22 2020, 22:29
This revision is now accepted and ready to land.Apr 22 2020, 22:29
Closed by commit rABC77355596721c: Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists. (authored by Alexander Leishman <leishman3@gmail.com>, committed by deadalnix). · Explain WhyApr 22 2020, 23:19
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC77355596721c: Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists..
deadalnix added a commit: rSTAGING77355596721c: Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists..May 5 2020, 19:05

Revision Contents
Changeset List

PathSize
src/
20 lines

Diff 19043

View Options

src/init.cpp

Loading...