Differential D5880
[backport#14532] net: Always default rpcbind to localhost, never "all interfaces" Authored by majcosta on Apr 29 2020, 11:51.
Details
We don't support binding to untrusted networks, so avoid a default where that is typical (luke-jr) 3615003952ffbc814bdb53d9d0e45790f152bd2f net: Always default rpcbind to localhost, never "all interfaces" f3cf95ffdfda935f28260eb34bf20c1449a200c5 tests: Modify rpc_bind to conform to #14532 behaviour. ninja check ./test/functional/test_runner/rpc_bind
Diff Detail
Event TimelineComment Actions [Bot Message] Comment Actions Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.
Snippet of first build failure: [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.gettime [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.util_time_GetTime [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_IsDigit [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseInt32 [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseInt64 [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseUInt32 [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseUInt64 [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseDouble [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_FormatParagraph [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_FormatSubVersion [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ParseFixedPoint [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_LockDirectory [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_DirIsWritable [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ConvertBits [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToLower [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_ToUpper [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_tests.test_Capitalize [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] util_threadnames_tests.util_threadnames_test_rename_threaded [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_block_tests.processnewblock_signals_ordering [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.block_subsidy_test [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.subsidy_limit_test [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] validation_tests.validation_load_external_block_file [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_test [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] versionbits_tests.versionbits_computeblockversion [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] work_comparator_tests.work_comparator [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] server_tests.server_IsDeprecatedRPCEnabled [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_file [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_directory [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_multiple [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] db_tests.getwalletenv_g_dbenvs_free_instance [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.bnb_search_test [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.knapsack_solver_test [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.ApproximateBestSubset [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] coinselector_tests.SelectCoins_test [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_default [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_custom [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_does_not_exist [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_directory [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_is_not_relative [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] init_tests.walletinit_verify_walletdir_no_trailing2 [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.psbt_updater_test [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] psbt_wallet_tests.parse_hd_keypath [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.scan_for_wallet_transactions [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importmulti_rescan [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.importwallet_rescan [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.coin_mark_dirty_immature_credit [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ComputeTimeSmart [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.LoadReceiveRequests [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.ListCoins [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_tests.wallet_disableprivkeys [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_name [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_purpose [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.write_erase_destdata [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] walletdb_tests.no_dest_fails [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.passphrase [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.encrypt [11:57:49]i: [Bitcoin_ABC_unit_tests_with_next_upgrade_activated] wallet_crypto_tests.decrypt [11:58:04]W: [Step 1/2] Process exited with code 1 [11:58:04]E: [Step 1/2] Process exited with code 1 (Step: Command Line) Comment Actions The test suite is broken, you need to investigate.
| ||||||||||||||||||||||||||