Page MenuHomePhabricator
Differential D5922

Finish PR14987 and clean up some functions
ClosedPublic
Actions

Authored by nakihito on Apr 30 2020, 21:27.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe55251f4329b: Finish PR14987 and clean up some functions
rABCe55251f4329b: Finish PR14987 and clean up some functions
Summary

Removes now unnecessary functions, etc. from the portioned backporting
of PR14987.

Depends on D5291, D5290, D5919, D5916, D5914, D5913, D5899

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched finish.diff

Verify finish.diff does not exist.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
FinishPR14987
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10528
Build 18870: Default Diff Build & Tests
Build 18869: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 30 2020, 21:27
Owners added a reviewer: Restricted Owners Package.Apr 30 2020, 21:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2020, 21:27
teamcity edited the summary of this revision. (Show Details)Apr 30 2020, 21:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 30 2020, 21:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 30 2020, 21:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10528: Diff 19324.Apr 30 2020, 21:37
deadalnix accepted this revision.May 1 2020, 00:47
This revision is now accepted and ready to land.May 1 2020, 00:47
Closed by commit rABCe55251f4329b: Finish PR14987 and clean up some functions (authored by nakihito). · Explain WhyMay 4 2020, 17:21
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCe55251f4329b: Finish PR14987 and clean up some functions.
nakihito added a commit: rSTAGINGe55251f4329b: Finish PR14987 and clean up some functions.May 5 2020, 19:18

Revision Contents
Changeset List

PathSize
src/
rpc/
4 lines
4 lines
64 lines
16 lines
16 lines
26 lines
30 lines
8 lines
7 lines
68 lines
wallet/
20 lines
90 lines
zmq/
2 lines

Diff 19324

View Options

src/rpc/abc.cpp

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/rpc/util.h

Loading...
View Options

src/rpc/util.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/zmq/zmqrpc.cpp

Loading...