Page MenuHomePhabricator
Differential D5948

[backport#15632] [wallet] Keep track of the best block time in the wallet
ClosedPublic
Actions

Authored by majcosta on May 4 2020, 08:26.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGecd969004275: [backport#15632] [wallet] Keep track of the best block time in the wallet
rABCecd969004275: [backport#15632] [wallet] Keep track of the best block time in the wallet
Summary

Move nTimeBestReceived (which is only used for wallet
rebroadcasts) into the wallet.

https://github.com/bitcoin/bitcoin/pull/15632/commits/f463cd107361a172a17e4c5510b06eb8a67aade0

Depends on D5947

This is a partial backport of Core PR15632

Test Plan
cmake .. -GNinja
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add_test_rebroadcast
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10570
Build 18951: Default Diff Build & Tests
Build 18950: arc lint + arc unit

Event Timeline

majcosta created this revision.May 4 2020, 08:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 4 2020, 08:26
teamcity edited the summary of this revision. (Show Details)May 4 2020, 08:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta edited the summary of this revision. (Show Details)May 4 2020, 08:27
majcosta added a parent revision: D5947: [backport#15646] [tests] Add test for wallet rebroadcasts.
teamcity added a comment.May 4 2020, 08:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 4 2020, 08:41

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10570: Diff 19396.May 4 2020, 08:41
majcosta requested review of this revision.May 4 2020, 08:41
jasonbcox accepted this revision.May 4 2020, 15:48
This revision is now accepted and ready to land.May 4 2020, 15:48
Closed by commit rABCecd969004275: [backport#15632] [wallet] Keep track of the best block time in the wallet (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 4 2020, 17:50
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCecd969004275: [backport#15632] [wallet] Keep track of the best block time in the wallet.
majcosta added a commit: rSTAGINGecd969004275: [backport#15632] [wallet] Keep track of the best block time in the wallet.May 5 2020, 19:19

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
11 lines
7 lines
5 lines
9 lines
wallet/
8 lines
13 lines

Diff 19396

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...