Page MenuHomePhabricator
Differential D6146

qa: Run more tests with wallet disabled
ClosedPublic
Actions

Authored by Fabien on May 19 2020, 21:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4340dc14f448: qa: Run more tests with wallet disabled
rABC4340dc14f448: qa: Run more tests with wallet disabled
Summary
Instead of skipping the whole test, only skip the wallet specific
section of a test if the wallet is not compiled in.

Backport of core PR14324.

Test Plan
ninja check-functional

cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check-functional
  1. Conflicts:
  2. .travis.yml
  3. test/functional/feature_config_args.py
  4. test/functional/feature_notifications.py
  5. test/functional/interface_bitcoin_cli.py
  6. test/functional/interface_zmq.py

Diff Detail

Event Timeline

Fabien created this revision.May 19 2020, 21:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2020, 21:06
Fabien requested review of this revision.May 19 2020, 21:06
teamcity edited the summary of this revision. (Show Details)May 19 2020, 21:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 19 2020, 21:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 21:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 21:06

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 21:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 21:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 21:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10869: Diff 20311.May 19 2020, 21:16
Fabien added a child revision: D6154: net: Use mockable time for tx download.May 20 2020, 10:04
deadalnix accepted this revision.May 20 2020, 11:38
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/feature_notifications.py
43 ↗(On Diff #20311)

This formatting is bad. When autopep8 does things like this, you should consider manual tweaking.

This revision is now accepted and ready to land.May 20 2020, 11:38
Fabien updated this revision to Diff 20329.May 20 2020, 12:19

Work around autopep8

teamcity added a comment.May 20 2020, 12:20

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 12:20

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 12:20

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

This revision was landed with ongoing or failed builds.May 20 2020, 12:20
Closed by commit rABC4340dc14f448: qa: Run more tests with wallet disabled (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4340dc14f448: qa: Run more tests with wallet disabled.
teamcity added a comment.May 20 2020, 12:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 12:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Fabien added a commit: rSTAGING4340dc14f448: qa: Run more tests with wallet disabled.May 20 2020, 12:25
teamcity added a comment.May 20 2020, 12:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10885: Diff 20329.May 20 2020, 12:30

Revision Contents
Changeset List

PathSize
test/
functional/
17 lines
102 lines
35 lines
26 lines
test_framework/
2 lines

Diff 20329

View Options

test/functional/feature_config_args.py

Loading...
View Options

test/functional/feature_notifications.py

Loading...
View Options

test/functional/interface_bitcoin_cli.py

Loading...
View Options

test/functional/interface_zmq.py

Loading...
View Options

test/functional/test_framework/address.py

Loading...