Page MenuHomePhabricator
Differential D6170

[backport#16118] gui: Enable open wallet menu on setWalletController
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 17:43.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGc2e77ef569a1: [backport#16118] gui: Enable open wallet menu on setWalletController
rABCc2e77ef569a1: [backport#16118] gui: Enable open wallet menu on setWalletController
Summary

https://github.com/bitcoin/bitcoin/pull/16118/commits/75485ef0962a53946f17b761c4445627b07e6eff

Depends on D6169

Backport of Core PR16118

Test Plan
ninja

I don't have access to a macOS box to check the menu is disabled while the splash screen loads, wat do

Diff Detail

Event Timeline

majcosta created this revision.May 20 2020, 17:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 17:43
majcosta requested review of this revision.May 20 2020, 17:43
teamcity edited the summary of this revision. (Show Details)May 20 2020, 17:44

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 17:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 17:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 17:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 17:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

deadalnix accepted this revision.May 20 2020, 17:45
This revision is now accepted and ready to land.May 20 2020, 17:45
teamcity added a comment.May 20 2020, 17:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 17:54

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10897: Diff 20365.May 20 2020, 17:55
majcosta added a child revision: D6172: [backport#16231] gui: Fix open wallet menu initialization order.May 20 2020, 18:56
Closed by commit rABCc2e77ef569a1: [backport#16118] gui: Enable open wallet menu on setWalletController (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 21 2020, 00:38
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc2e77ef569a1: [backport#16118] gui: Enable open wallet menu on setWalletController.
majcosta added a commit: rSTAGINGc2e77ef569a1: [backport#16118] gui: Enable open wallet menu on setWalletController.

Revision Contents
Changeset List

PathSize
src/
qt/
5 lines

Diff 20365

View Options

src/qt/bitcoingui.cpp

Loading...