Page MenuHomePhabricator
Differential D6181

[backport#16348] gui: Fix missing qRegisterMetaType(WalletModel*)
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 22:29.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC046c789d43f3: [backport#16348] gui: Fix missing qRegisterMetaType(WalletModel*)
Summary

https://github.com/bitcoin/bitcoin/pull/16348/commits/f27bd96b5fdc2921d93c44bbf422bff0e979c4de

Depends on D6180

Partial backport of Core PR16348

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.May 20 2020, 22:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 22:29
majcosta requested review of this revision.May 20 2020, 22:29
teamcity edited the summary of this revision. (Show Details)May 20 2020, 22:29

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 20 2020, 22:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 22:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 22:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 22:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 22:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

majcosta edited the summary of this revision. (Show Details)May 20 2020, 22:36
majcosta added a parent revision: D6180: [backport#15091] Qt: Fix update headers-count.
majcosta added a child revision: D6183: [backport#16348] qt: Assert QMetaObject::invokeMethod result.May 20 2020, 22:36
jasonbcox requested changes to this revision.May 20 2020, 22:37
jasonbcox added a subscriber: jasonbcox.

Any reason to not do the whole backport?

This revision now requires changes to proceed.May 20 2020, 22:37
teamcity added a comment.May 20 2020, 22:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10916: Diff 20397.May 20 2020, 22:40
jasonbcox accepted this revision.May 20 2020, 22:46

Talked offline to clear up when splitting up backports is reasonable. Since there's a large stack we'll let it slide for now.

This revision is now accepted and ready to land.May 20 2020, 22:46
Closed by commit rABC046c789d43f3: [backport#16348] gui: Fix missing qRegisterMetaType(WalletModel*) (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by majcosta). · Explain WhyMay 21 2020, 01:06
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC046c789d43f3: [backport#16348] gui: Fix missing qRegisterMetaType(WalletModel*).

Revision Contents
Changeset List

PathSize
src/
qt/
3 lines

Diff 20397

View Options

src/qt/bitcoin.cpp

Loading...