[backport#16839] Avoid using g_rpc_node global in wallet code
ClosedPublic
Actions

Authored by majcosta on Jun 6 2020, 22:01.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC7a4fc02d8de7: [backport#16839] Avoid using g_rpc_node global in wallet code

Summary

Wallet code should use interfaces::Chain and not directly access to node state.

Add a g_rpc_chain replacement global for wallet code to use, and move
g_rpc_node definition to a libbitcoin_server source file so there are link
errors if wallet code tries to access it.

https://github.com/bitcoin/bitcoin/pull/16839/commits/362ded410b8cb1104b7ef31ff8488fec4824a7d5

Depends on D6418

Concludes backport of Core PR16839

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16839

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11277
Build 21347: Default Diff Build & Tests
Build 21346: Build without Wallet
Build 21345: Build with clang-10
Build 21344: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 6 2020, 22:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 6 2020, 22:01

majcosta requested review of this revision.Jun 6 2020, 22:01

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11268: Diff 21005.Jun 6 2020, 22:14

What about src/rpc/blockchain.h ?

src/interfaces/wallet.cpp
501 ↗	(On Diff #21005)	Why return? This does nothing, you can remove it.
src/wallet/rpcwallet.cpp
3167 ↗	(On Diff #21005)	This isn't in the original PR. Can you explain?