Page MenuHomePhabricator
Differential D6446

[backport#15930] rpc: Add getbalances RPC
ClosedPublic
Actions

Authored by majcosta on Jun 7 2020, 20:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1b1b61fd39cf: [backport#15930] rpc: Add getbalances RPC
Summary

https://github.com/bitcoin/bitcoin/pull/15930/commits/999931cf8f167c7547f1015cdf05437a460c27f0

Depends on D6445

Partial backport of Core PR15930

Test Plan
ninja
./src/bitcoind -regtest -daemon
./src/bitcoin-cli getwalletinfo help

Check that output is correct

./src/bitcoin-cli getbalances
./src/bitcoin-cli getbalances help

Ditto

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jun 7 2020, 20:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2020, 20:11
majcosta requested review of this revision.Jun 7 2020, 20:11
teamcity edited the summary of this revision. (Show Details)Jun 7 2020, 20:11

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D6447: [backport#15930] rpc: Deprecate getunconfirmedbalance and getwalletinfo balances.Jun 7 2020, 20:21
Harbormaster completed remote builds in B11302: Diff 21052.Jun 7 2020, 20:21
majcosta updated this revision to Diff 21055.Jun 7 2020, 20:49

rebase

deadalnix accepted this revision.Jun 7 2020, 20:56
This revision is now accepted and ready to land.Jun 7 2020, 20:56
Harbormaster completed remote builds in B11305: Diff 21055.Jun 7 2020, 20:59
Closed by commit rABC1b1b61fd39cf: [backport#15930] rpc: Add getbalances RPC (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 9 2020, 16:37
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC1b1b61fd39cf: [backport#15930] rpc: Add getbalances RPC.

Revision Contents
Changeset List

PathSize
src/
wallet/
99 lines
test/
functional/
18 lines

Diff 21152

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_balance.py

Loading...