Differential D6586

[backport#16659] refactoring: Remove unused includes
ClosedPublic
Actions

Authored by majcosta on Jun 15 2020, 18:30.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCa3160568efbd: [backport#16659] refactoring: Remove unused includes

Summary

084e17cebd424b8e8ced674bc810eef4e6ee5d3b Remove unused includes (practicalswift)

Pull request description:

As requested by MarcoFalke in https://github.com/bitcoin/bitcoin/pull/16273#issuecomment-521332089:

This PR removes unused includes.

Please note that in contrast to #16273 I'm limiting the scope to the trivial cases of pure removals (i.e. no includes added) to make reviewing easier.

I'm seeking "Concept ACK":s for this obviously non-urgent minor cleanup.

Rationale:
* Avoids unnecessary re-compiles in case of header changes.
* Makes reasoning about code dependencies easier.
* Reduces compile-time memory usage.
* Reduces compilation time.
* Warm fuzzy feeling of being lean :-)

ACKs for top commit:

ryanofsky:
  Code review ACK 084e17cebd424b8e8ced674bc810eef4e6ee5d3b. PR only removes include lines and it still compiles. In the worst case someone might have to explicitly add an include later for something now included implicitly. But maybe some effort was taken to avoid this, and it wouldn't be a tragedy anyway.

Backport of Core PR16659

Test Plan

ninja check-all
ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16659

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11498
Build 22137: Default Diff Build & Tests	Link to the build
Build 22136: Build without Wallet	Link to the build
Build 22135: Build with clang-10	Link to the build
Build 22134: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 15 2020, 18:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 18:30

majcosta requested review of this revision.Jun 15 2020, 18:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

rebase

Harbormaster completed remote builds in B11497: Diff 21411.Jun 15 2020, 18:47

Harbormaster completed remote builds in B11498: Diff 21412.Jun 15 2020, 18:51

deadalnix accepted this revision.Jun 15 2020, 20:43

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/zmq/zmqnotificationinterface.h
9	keep

This revision is now accepted and ready to land.Jun 15 2020, 20:43

Closed by commit rABCa3160568efbd: [backport#16659] refactoring: Remove unused includes (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyJun 15 2020, 20:56

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCa3160568efbd: [backport#16659] refactoring: Remove unused includes.

Revision Contents
Changeset List

Path

Size

src/

arith_uint256.h

2 lines

arith_uint256.cpp

2 lines

bench/

1 line

1 line

crypto_hash.cpp

1 line

duplicate_inputs.cpp

3 lines

1 line

mempool_eviction.cpp

2 lines

rollingbloom.cpp

1 line

rpc_mempool.cpp

2 lines

bitcoin-cli.cpp

1 line

1 line

bitcoin-wallet.cpp

2 lines

1 line

1 line

consensus/

2 lines

crypto/

1 line

1 line

sha256_shani.cpp

1 line

1 line

3 lines

2 lines

1 line

1 line

index/

1 line

interfaces/

2 lines

4 lines

1 line

1 line

2 lines

3 lines

net_processing.cpp

1 line

1 line

node/

2 lines

2 lines

1 line

primitives/

1 line

1 line

qt/

bantablemodel.cpp

2 lines

1 line

peertablemodel.cpp

1 line

signverifymessagedialog.cpp

1 line

splashscreen.cpp

1 line

transactiondesc.cpp

1 line

walletframe.cpp

1 line

1 line

walletmodeltransaction.h

2 lines

2 lines

1 line

rpc/

1 line

1 line

rawtransaction.cpp

2 lines

2 lines

2 lines

script/

1 line

1 line

2 lines

1 line

1 line

2 lines

1 line

test/

bip32_tests.cpp

1 line

compress_tests.cpp

2 lines

policyestimator_tests.cpp

1 line

1 line

skiplist_tests.cpp

1 line

txindex_tests.cpp

1 line

threadinterrupt.h

1 line

2 lines

1 line

1 line

1 line

1 line

util/

1 line

1 line

1 line

1 line

1 line

2 lines

3 lines

validationinterface.cpp

2 lines

wallet/

1 line

3 lines

2 lines

1 line

1 line

1 line

2 lines

2 lines

1 line

1 line

3 lines

1 line

1 line

zmq/

2 lines

zmqnotificationinterface.h

2 lines

zmqnotificationinterface.cpp

1 line

Diff 21412

src/arith_uint256.h

Loading...

src/arith_uint256.cpp

Loading...

src/bench/base58.cpp

Loading...

src/bench/bench.h

Loading...

src/bench/crypto_hash.cpp

Loading...

src/bench/duplicate_inputs.cpp

Loading...

src/bench/lockedpool.cpp

Loading...

src/bench/mempool_eviction.cpp

Loading...

src/bench/rollingbloom.cpp

Loading...

src/bench/rpc_mempool.cpp

Loading...

src/bitcoin-cli.cpp

Loading...

src/bitcoin-tx.cpp

Loading...

src/bitcoin-wallet.cpp

Loading...

src/bitcoind.cpp

Loading...

src/compressor.cpp

Loading...

src/consensus/merkle.h

Loading...

src/crypto/aes.cpp

Loading...

src/crypto/sha256.cpp

Loading...

src/crypto/sha256_shani.cpp

Loading...

src/dbwrapper.h

Loading...

src/httprpc.h

Loading...

src/httprpc.cpp

Loading...

src/httpserver.h

Loading...

src/httpserver.cpp

Loading...

src/index/base.h

Loading...

src/interfaces/chain.cpp

Loading...

src/interfaces/node.cpp

Loading...

src/interfaces/wallet.cpp

Loading...

src/key_io.cpp

Loading...

src/miner.cpp

Loading...

src/net.cpp

Loading...

src/net_processing.cpp

Loading...

src/netaddress.h

Loading...

src/node/coinstats.cpp

Loading...

src/noui.cpp

Loading...

src/prevector.h

Loading...

src/primitives/block.cpp

Loading...

src/psbt.cpp

Loading...

src/qt/bantablemodel.cpp

Loading...

src/qt/bitcoin.cpp

Loading...

src/qt/peertablemodel.cpp

Loading...

src/qt/signverifymessagedialog.cpp

Loading...

src/qt/splashscreen.cpp

Loading...

src/qt/transactiondesc.cpp

Loading...

src/qt/walletframe.cpp

Loading...

src/qt/walletmodel.h

Loading...

src/qt/walletmodeltransaction.h

Loading...

src/random.cpp

Loading...

src/rest.cpp

Loading...

src/rpc/client.cpp

Loading...

src/rpc/net.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/rpc/server.h

Loading...

src/rpc/server.cpp

Loading...

src/script/interpreter.h

Loading...

src/script/keyorigin.h

Loading...

src/script/sign.h

Loading...

src/script/standard.h

Loading...

src/serialize.h

Loading...

src/streams.h

Loading...

src/sync.cpp

Loading...

src/test/bip32_tests.cpp

Loading...

src/test/compress_tests.cpp

Loading...

src/test/policyestimator_tests.cpp

Loading...

src/test/pow_tests.cpp

Loading...

src/test/skiplist_tests.cpp

Loading...

src/test/txindex_tests.cpp

Loading...

src/threadinterrupt.h

Loading...

src/torcontrol.h

Loading...

src/txdb.h

Loading...

src/ui_interface.h

Loading...

src/uint256.h

Loading...

src/uint256.cpp

Loading...

src/util/moneystr.h

Loading...

src/util/moneystr.cpp

Loading...

src/util/string.h

Loading...

src/util/system.cpp

Loading...

src/util/translation.h

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

src/validationinterface.cpp

Loading...

src/wallet/crypter.h

Loading...

src/wallet/crypter.cpp

Loading...

src/wallet/db.h

Loading...

src/wallet/fees.cpp

Loading...

src/wallet/init.cpp

Loading...

src/wallet/ismine.cpp

Loading...

src/wallet/psbtwallet.h

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/wallet.h

Loading...

src/wallet/wallet.cpp

Loading...

src/wallet/walletdb.h

Loading...

src/wallet/wallettool.h

Loading...

src/warnings.h

Loading...

src/zmq/zmqconfig.h

Loading...

src/zmq/zmqnotificationinterface.h

Loading...

src/zmq/zmqnotificationinterface.cpp

Loading...