Differential D6789

[fix] actually move tx_check.cpp from libserver to libbitcoin consensus
ClosedPublic
Actions

Authored by majcosta on Jun 30 2020, 21:20.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABCe3f3596aeccb: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus

Summary

I messed up https://reviews.bitcoinabc.org/D5961, it is still on libserver
for the cmake build.

That was not really a problem until I came back to try and get D6256 done,
now that D6710 is landed.

Test Plan

ninja check-all [with -DBUILD_BITCOIN_WALLET=OFF as well]

make check-recursive
./test/functional/test_runner.py [with --disable-wallet as well]

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_D5961

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11797
Build 23225: Default Diff Build & Tests	Link to the build
Build 23224: Build without Wallet	Link to the build
Build 23223: Build with clang-10	Link to the build
Build 23222: arc lint + arc unit

Event Timeline

majcosta created this revision.Jun 30 2020, 21:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 30 2020, 21:20

majcosta requested review of this revision.Jun 30 2020, 21:20

Harbormaster completed remote builds in B11797: Diff 21903.Jun 30 2020, 21:35

jasonbcox accepted this revision.Jun 30 2020, 22:26

This revision is now accepted and ready to land.Jun 30 2020, 22:26

Closed by commit rABCe3f3596aeccb: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus (authored by majcosta). · Explain WhyJun 30 2020, 22:41

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCe3f3596aeccb: [fix] actually move tx_check.cpp from libserver to libbitcoin consensus.

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

2 lines

Diff 21903

View Options

[fix] actually move tx_check.cpp from libserver to libbitcoin consensusClosedPublicActions