Paths

Table of Contentst

Differential D6828

[avalanche] Remove getPubkey API
ClosedPublic
Actions

Authored by deadalnix on Jul 6 2020, 18:11.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4148611617c6: [avalanche] Remove getPubkey API

Summary

Instead, provide a more generic forNode function that provides a temporary access to the node object. This ensure locking remains correct while not requiring accessor for anythign and everything.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avagetpubkey

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11864
Build 23436: Default Diff Build & Tests	Link to the build
Build 23435: Build without Wallet	Link to the build
Build 23434: Build with clang-10	Link to the build
Build 23433: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 6 2020, 18:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 6 2020, 18:11

deadalnix requested review of this revision.Jul 6 2020, 18:11

Harbormaster completed remote builds in B11864: Diff 22023.Jul 6 2020, 18:27

deadalnix added a child revision: D6830: [avalanche] Move AvalancheNode to its own file.Jul 6 2020, 20:47

jasonbcox accepted this revision.Jul 6 2020, 21:23

This revision is now accepted and ready to land.Jul 6 2020, 21:23

Closed by commit rABC4148611617c6: [avalanche] Remove getPubkey API (authored by deadalnix). · Explain WhyJul 6 2020, 21:42

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC4148611617c6: [avalanche] Remove getPubkey API.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

31 lines

17 lines

net_processing.cpp

24 lines

Diff 22023

src/avalanche/processor.h

Loading...

src/avalanche/processor.cpp

Loading...

src/net_processing.cpp

Loading...