Page MenuHomePhabricator

[refactor] factor CBlockIndex out of chain.h
ClosedPublic

Authored by majcosta on Jul 21 2020, 02:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9c4a4005f423: [refactor] factor CBlockIndex out of chain.h
Summary

seems like the right thing to do. looks like we're just two small backports away from Core where CBlockIndex is concerned, so give it its own translation unit

Test Plan
ninja check check-functional

Event Timeline

missing newline at the end of blockindex.h

Fabien requested changes to this revision.Jul 21 2020, 09:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/CMakeLists.txt
473 ↗(On Diff #22393)

I don't think this is the right library

src/avalanche/test/processor_tests.cpp
9 ↗(On Diff #22393)

blockindex.h is not enough ?

src/chain.h
50 ↗(On Diff #22393)

The comment should be moved as well

This revision now requires changes to proceed.Jul 21 2020, 09:34
majcosta added inline comments.
src/avalanche/test/processor_tests.cpp
9 ↗(On Diff #22393)

this test calls LookupBlockIndex which is still in chain.h

this TU includes avalanche/processor.h, which includes blockindexworkcomparator.h which included chain.h up until this diff, so this is needed now

majcosta marked an inline comment as done.

moved comment that should've been there in the first place and moved source files to the Server library

This revision is now accepted and ready to land.Jul 22 2020, 06:52