Differential D6988

[refactor] factor CBlockIndex out of chain.h
ClosedPublic
Actions

Authored by majcosta on Jul 21 2020, 02:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC9c4a4005f423: [refactor] factor CBlockIndex out of chain.h

Summary

seems like the right thing to do. looks like we're just two small backports away from Core where CBlockIndex is concerned, so give it its own translation unit

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

factor_out_blockindex

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12085
Build 24131: Default Diff Build & Tests	build-diff
Build 24130: Build without Wallet	build-without-wallet
Build 24129: Build with clang-10	build-clang-10
Build 24128: arc lint + arc unit

Event Timeline

majcosta created this revision.Jul 21 2020, 02:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2020, 02:36

majcosta requested review of this revision.Jul 21 2020, 02:36

missing newline at the end of blockindex.h

Harbormaster completed remote builds in B12080: Diff 22392.Jul 21 2020, 02:58

Harbormaster completed remote builds in B12081: Diff 22393.Jul 21 2020, 03:01

Fabien requested changes to this revision.Jul 21 2020, 09:34

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/CMakeLists.txt
473 ↗	(On Diff #22393)	I don't think this is the right library
src/avalanche/test/processor_tests.cpp
9 ↗	(On Diff #22393)	blockindex.h is not enough ?
src/chain.h
50 ↗	(On Diff #22393)	The comment should be moved as well

This revision now requires changes to proceed.Jul 21 2020, 09:34

majcosta marked 3 inline comments as done.Jul 21 2020, 15:35

majcosta added inline comments.

src/avalanche/test/processor_tests.cpp
9 ↗	(On Diff #22393)	this test calls LookupBlockIndex which is still in chain.h this TU includes avalanche/processor.h, which includes blockindexworkcomparator.h which included chain.h up until this diff, so this is needed now