Page MenuHomePhabricator
Differential D7040

[backport#16451 3/3][wallet] Remove CMerkleTx serialization logic
ClosedPublic
Actions

Authored by majcosta on Jul 25 2020, 07:17.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC5fd2927bcdcb: [backport#16451 3/3][wallet] Remove CMerkleTx serialization logic
Summary

CMerkleTx is only used for deserialization of old wallet files. Remove
the serialization logic, and tidy up CWalletTx serialization logic.

https://github.com/bitcoin/bitcoin/pull/16451/commits/05b56d1c937b7667ad51400d2f9fb674af72953f

Depends on D7039

Concludes backport of Core PR16451

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Jul 25 2020, 07:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2020, 07:17
majcosta requested review of this revision.Jul 25 2020, 07:17
majcosta retitled this revision from [backport#16451][wallet] Remove CMerkleTx serialization logic to [backport#16451 3/3][wallet] Remove CMerkleTx serialization logic.Jul 25 2020, 07:18
Harbormaster completed remote builds in B12160: Diff 22511.Jul 25 2020, 07:28
deadalnix accepted this revision.Jul 25 2020, 13:06
This revision is now accepted and ready to land.Jul 25 2020, 13:06
Closed by commit rABC5fd2927bcdcb: [backport#16451 3/3][wallet] Remove CMerkleTx serialization logic (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyJul 26 2020, 13:53
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC5fd2927bcdcb: [backport#16451 3/3][wallet] Remove CMerkleTx serialization logic.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
40 lines

Diff 22511

View Options

src/wallet/wallet.h

Loading...