Page MenuHomePhabricator
Differential D7514

[backport#15931 9/9] Remove getBlockDepth method from Chain::interface
ClosedPublic
Actions

Authored by majcosta on Sep 22 2020, 04:05.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd0e0b2ca1116: [backport#15931 9/9] Remove getBlockDepth method from Chain::interface
Summary

Pass conflicting height in CWallet::MarkConflicted

https://github.com/bitcoin/bitcoin/pull/15931/commits/36b68de5b2938722911db900ca299f7008780d01

Depends on D7513

Concludes backport of Core PR15931

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 22 2020, 04:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 04:05
majcosta requested review of this revision.Sep 22 2020, 04:05
teamcity edited the summary of this revision. (Show Details)Sep 22 2020, 04:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12844: Diff 23656.Sep 22 2020, 04:12
Fabien accepted this revision.Sep 22 2020, 06:38
This revision is now accepted and ready to land.Sep 22 2020, 06:38
Closed by commit rABCd0e0b2ca1116: [backport#15931 9/9] Remove getBlockDepth method from Chain::interface (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain WhySep 22 2020, 15:01
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCd0e0b2ca1116: [backport#15931 9/9] Remove getBlockDepth method from Chain::interface.

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
5 lines
wallet/
3 lines

Diff 23656

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...