Page MenuHomePhabricator
Differential D7510

[backport#15931 5/9] Refactor some importprunedfunds checks with guard clause
ClosedPublic
Actions

Authored by majcosta on Sep 22 2020, 02:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe2178e2316ae: [backport#15931 5/9] Refactor some importprunedfunds checks with guard clause
Summary

Credit to jkczyz

https://github.com/bitcoin/bitcoin/pull/15931/commits/769ff05e48fb53d4b62c59060424a0fea71d0aab

Depends on D7509

Partial backport of Core PR15931

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

majcosta created this revision.Sep 22 2020, 02:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2020, 02:35
majcosta requested review of this revision.Sep 22 2020, 02:35
teamcity edited the summary of this revision. (Show Details)Sep 22 2020, 02:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B12840: Diff 23651.Sep 22 2020, 02:46
majcosta added a child revision: D7511: [backport#15931 6/9] Only return early from BlockUntilSyncedToCurrentChain if current tip is exact match.Sep 22 2020, 03:05
Fabien accepted this revision.Sep 22 2020, 06:12
This revision is now accepted and ready to land.Sep 22 2020, 06:12
Fabien added inline comments.Sep 22 2020, 06:13
src/wallet/rpcdump.cpp
440 ↗(On Diff #23651)

size_t

majcosta updated this revision to Diff 23666.Sep 22 2020, 14:50

unsigned int into size_t

This revision was landed with ongoing or failed builds.Sep 22 2020, 14:58
Closed by commit rABCe2178e2316ae: [backport#15931 5/9] Refactor some importprunedfunds checks with guard clause (authored by Antoine Riard <ariard@student.42.fr>, committed by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe2178e2316ae: [backport#15931 5/9] Refactor some importprunedfunds checks with guard clause.
Harbormaster completed remote builds in B12852: Diff 23666.Sep 22 2020, 15:02

Revision Contents
Changeset List

PathSize
src/
wallet/
35 lines

Diff 23666

View Options

src/wallet/rpcdump.cpp

Loading...