Page MenuHomePhabricator
Differential D7736

[refactor] replace calls to Params() CWallet chainParams member
ClosedPublic
Actions

Authored by majcosta on Oct 2 2020, 10:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC314bf14ecf3e: [refactor] replace calls to Params() CWallet chainParams member
Summary

as suggested in D7041, in the future this will make it easier to grab these params from CWallet's interface::chain() instead

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
replace_params_with_cwallet_params
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13171
Build 26392: Build Diffbuild-without-wallet · lint-circular-dependencies · build-diff · build-clang-tidy · build-clang
Build 26391: arc lint + arc unit

Event Timeline

majcosta created this revision.Oct 2 2020, 10:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2020, 10:33
majcosta requested review of this revision.Oct 2 2020, 10:34
Harbormaster completed remote builds in B13152: Diff 24199.Oct 2 2020, 10:45
deadalnix requested changes to this revision.Oct 2 2020, 14:09
deadalnix added a subscriber: deadalnix.

That is very good, but you went overboard with the last one.

src/wallet/wallet.cpp
2302 ↗(On Diff #24199)

revert

This revision now requires changes to proceed.Oct 2 2020, 14:09
deadalnix mentioned this in D7744: [refactor] replace global Params() use with CWallet chainParams member.Oct 2 2020, 14:37
majcosta updated this revision to Diff 24212.Oct 2 2020, 15:18

corrected

Harbormaster completed remote builds in B13162: Diff 24212.Oct 2 2020, 15:30
deadalnix accepted this revision.Oct 2 2020, 19:02
This revision is now accepted and ready to land.Oct 2 2020, 19:02
majcosta updated this revision to Diff 24230.Oct 2 2020, 19:08

rebase

This revision was landed with ongoing or failed builds.Oct 2 2020, 19:09
Closed by commit rABC314bf14ecf3e: [refactor] replace calls to Params() CWallet chainParams member (authored by majcosta). · Explain Why
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC314bf14ecf3e: [refactor] replace calls to Params() CWallet chainParams member.
Harbormaster completed remote builds in B13171: Diff 24230.Oct 2 2020, 19:36

Revision Contents
Changeset List

PathSize
src/
wallet/
7 lines
29 lines
4 lines

Diff 24230

View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...