Page MenuHomePhabricator
Differential D925

Refactor RPC: Access wallet through GetWalletForJSONRPCRequest
ClosedPublic
Actions

Authored by deadalnix on Jan 9 2018, 23:36.

Details

Reviewers
schancel
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGfa0ab22b2e19: Refactor RPC: Access wallet through GetWalletForJSONRPCRequest
rABCfa0ab22b2e19: Refactor RPC: Access wallet through GetWalletForJSONRPCRequest
Summary

Partially backport core's PR8775, namely:

RPC/Wallet: Pass CWallet as pointer to helper functions
RPC: Do all wallet access through new GetWalletForJSONRPCRequest

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
walletrpcrefac
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1563
Build 1563: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 9 2018, 23:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 9 2018, 23:36
deadalnix updated this revision to Diff 2432.Jan 10 2018, 00:28

Include various nits made later on to these files.

deadalnix added a child revision: D926: Various wallet improvements.Jan 10 2018, 00:48
jasonbcox added a subscriber: jasonbcox.Jan 10 2018, 01:46

The rest looks good to me.

src/rpc/server.h
231 ↗(On Diff #2432)

Remove first "should" in this comment.

src/wallet/rpcdump.cpp
1207 ↗(On Diff #2432)

Looks like this newline should be removed

jasonbcox requested changes to this revision.Jan 10 2018, 19:37
This revision now requires changes to proceed.Jan 10 2018, 19:37
schancel accepted this revision.Jan 10 2018, 20:38
deadalnix updated this revision to Diff 2440.Jan 10 2018, 21:00

Fix nonsensical sentence in comments.

jasonbcox accepted this revision.Jan 10 2018, 21:09
This revision is now accepted and ready to land.Jan 10 2018, 21:09
Closed by commit rABCfa0ab22b2e19: Refactor RPC: Access wallet through GetWalletForJSONRPCRequest (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by deadalnix). · Explain WhyJan 10 2018, 21:11
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
rpc/
4 lines
61 lines
17 lines
12 lines
wallet/
267 lines
598 lines

Diff 2431

View Options

src/rpc/misc.h

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...