Page MenuHomePhabricator
Differential D7801

[backport#17889] wallet: Improve CWallet:MarkDestinationsDirty
ClosedPublic
Actions

Authored by majcosta on Oct 7 2020, 15:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC7cec11d3ed10: [backport#17889] wallet: Improve CWallet:MarkDestinationsDirty
Summary

2b1641492fbf81e2c5a95f3e580811ca8700adc5 wallet: Improve CWallet:MarkDestinationsDirty (João Barbosa)

Pull request description:

Improve `CWallet:MarkDestinationsDirty` by skipping transactions that already have the cache invalidated. Skipping a transaction avoids at worst case extracting all output destinations.

Depends on D7685

Backport of Core PR17889

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Oct 7 2020, 15:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2020, 15:34
majcosta requested review of this revision.Oct 7 2020, 15:34
teamcity edited the summary of this revision. (Show Details)Oct 7 2020, 15:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B13239: Diff 24340.Oct 7 2020, 15:46
deadalnix accepted this revision.Oct 7 2020, 18:28
This revision is now accepted and ready to land.Oct 7 2020, 18:28
Closed by commit rABC7cec11d3ed10: [backport#17889] wallet: Improve CWallet:MarkDestinationsDirty (authored by Samuel Dobson <dobsonsa68@gmail.com>, committed by majcosta). · Explain WhyOct 7 2020, 18:59
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC7cec11d3ed10: [backport#17889] wallet: Improve CWallet:MarkDestinationsDirty.

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
1 line
8 lines
6 lines

Diff 24356

View Options

src/wallet/test/coinselector_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...