Differential D8385

Add adaptation of the descriptor test that are using segwit in Core
ClosedPublic
Actions

Authored by deadalnix on Nov 13 2020, 00:55.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCd089e4f386df: Add adaptation of the descriptor test that are using segwit in Core

Summary

When removed, we were not checking for hardened derrivation. So rather than simply removeing them, adapting them is a better choice.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

desctstadapt

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14015
Build 28037: Build Diff	lint-circular-dependencies · build-clang · build-without-wallet · build-debug · build-clang-tidy · build-diff
Build 28036: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 13 2020, 00:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2020, 00:55

deadalnix requested review of this revision.Nov 13 2020, 00:55

Harbormaster completed remote builds in B14015: Diff 25699.Nov 13 2020, 01:03

deadalnix added a child revision: D8386: Cache the immediate derivation parent xpub.Nov 13 2020, 01:22

majcosta accepted this revision.Nov 13 2020, 04:52

This revision is now accepted and ready to land.Nov 13 2020, 04:52

Closed by commit rABCd089e4f386df: Add adaptation of the descriptor test that are using segwit in Core (authored by deadalnix). · Explain WhyNov 13 2020, 12:59

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd089e4f386df: Add adaptation of the descriptor test that are using segwit in Core.

Revision Contents
Changeset List

Path

Size

src/

test/

descriptor_tests.cpp

70 lines

Diff 25699

View Options

src/test/descriptor_tests.cpp

Add adaptation of the descriptor test that are using segwit in CoreClosedPublicActions