Save watch only key timestamps when reimporting keys
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2018, 22:45.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGfe14ea286e6d: Save watch only key timestamps when reimporting keys
rABCfe14ea286e6d: Save watch only key timestamps when reimporting keys

Summary

Previously if an existing watch only key was reimported with a new timestamp,
the new timestamp would not be saved in the key metadata, and would not be used
to update the wallet nTimeFirstKey value (which could cause rescanning to start
at the wrong point and miss transactions).

Issue was pointed out by Jonas Schnelli <dev@jonasschnelli.ch> in
https://github.com/bitcoin/bitcoin/pull/9108#issuecomment-279715550

Backport core's PR9818 and PR11483

Test Plan

make check
./test/functional/test_runner.py importmulti

Diff Detail

Repository

rABC Bitcoin ABC

Branch

addwatchonly

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1650
Build 1650: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 17 2018, 22:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2018, 22:45

Harbormaster completed remote builds in B1650: Diff 2570.Jan 17 2018, 22:46

deadalnix added a child revision: D982: [tests] Functional tests call self.start_node(s) and self.stop_node(s).Jan 19 2018, 01:47

jasonbcox accepted this revision.Jan 19 2018, 04:22

This revision is now accepted and ready to land.Jan 19 2018, 04:22

Closed by commit rABCfe14ea286e6d: Save watch only key timestamps when reimporting keys (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyJan 19 2018, 15:24

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcdump.cpp

20 lines

test/

functional/

importmulti.py

32 lines

Diff 2570

View Options

src/wallet/rpcdump.cpp