Page MenuHomePhabricator
Differential D8578

Add script to build CashTab as browser extension
ClosedPublic
Actions

Authored by bytesofman on Dec 2 2020, 13:30.

Details

Reviewers
alcipir
deadalnix
majcosta
Group Reviewers
Restricted Project
Commits
rABC83024066fcfe: Add script to build CashTab as browser extension
Summary

Build CashTab as Chrome or Brave browser extension

Test Plan
  1. npm run extension
  2. Open Chrome or Brave
  3. Navigate to chrome://extensions/ (or brave://extensions/)
  4. Enable Developer Mode
  5. Click "Load unpacked"
  6. Select the extension/dist folder that was created with npm run extension

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-as-extension
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14273
Build 28523: Build Diff
Build 28522: arc lint + arc unit

Event Timeline

bytesofman created this revision.Dec 2 2020, 13:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2020, 13:30
bytesofman requested review of this revision.Dec 2 2020, 13:30
Harbormaster completed remote builds in B14272: Diff 26145.Dec 2 2020, 13:30
bytesofman updated this revision to Diff 26146.Dec 2 2020, 13:56

Removing Bitcoin Cash from manifest description

Harbormaster completed remote builds in B14273: Diff 26146.Dec 2 2020, 13:57
majcosta requested changes to this revision.Dec 2 2020, 18:52
majcosta added a subscriber: majcosta.

'busy' spinner when you send a transaction seems not to be spinning around its center:

cashtab_spínner.gif (648×376 px, 240 KB)

This revision now requires changes to proceed.Dec 2 2020, 18:52
bytesofman added a comment.Dec 2 2020, 19:20
In D8578#198198, @majcosta wrote:

'busy' spinner when you send a transaction seems not to be spinning around its center:

cashtab_spínner.gif (648×376 px, 240 KB)

Unfortunately the spinner issue was introduced earlier. I will correct it in a later diff.

majcosta accepted this revision.Dec 2 2020, 19:36

talked offline, not blocking

This revision is now accepted and ready to land.Dec 2 2020, 19:36
Closed by commit rABC83024066fcfe: Add script to build CashTab as browser extension (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyDec 2 2020, 19:47
This revision was automatically updated to reflect the committed changes.
Joey King <joseph.roy.king@gmail.com> added a commit: rABC83024066fcfe: Add script to build CashTab as browser extension.

Revision Contents
Changeset List

PathSize
web/
cashtab/
5 lines
9 lines
extension/
9 lines
public/
20 lines
src/
assets/
21 lines
components/
411 lines
278 lines
1 line
scripts/
60 lines

Diff 26146

View Options

web/cashtab/.gitignore

Loading...
View Options

web/cashtab/README.md

Loading...
View Options

web/cashtab/extension/README.md

Loading...
View Options

web/cashtab/extension/public/manifest.json

Loading...
View Options

web/cashtab/extension/src/assets/popout.svg

Loading...
View Options

web/cashtab/extension/src/components/App.css

Loading...
View Options

web/cashtab/extension/src/components/App.js

Loading...
View Options

web/cashtab/package.json

Loading...
View Options

web/cashtab/scripts/extension.sh

Loading...