Page MenuHomePhabricator
Differential D8726

[net/refactor] Rework ThreadOpenConnections logic
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 12:44.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC5c39c9d8f014: [net/refactor] Rework ThreadOpenConnections logic
Summary
Make the connection counts explicit and extract into interface functions
around m_conn_type. Using explicit counting and switch statements where
possible should help prevent counting bugs in the future.

Partial backport (16/19) of core PR19316:
https://github.com/bitcoin/bitcoin/pull/19316/commits/7f7b83deb2427599c129f4ff581d4d045461e459

Depends on D8725.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Dec 21 2020, 12:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 12:44
Fabien requested review of this revision.Dec 21 2020, 12:44
teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 12:44
Fabien added a child revision: D8727: [net/refactor] Simplify multiple-connection checks.Dec 21 2020, 12:53
Harbormaster completed remote builds in B14477: Diff 26472.Dec 21 2020, 13:03
majcosta requested changes to this revision.Dec 21 2020, 13:59
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/net.cpp
2007–2013 ↗(On Diff #26472)

there was a change to this comment, try ticking "Hide whitespace changes" on Github and it'll be clear

This revision now requires changes to proceed.Dec 21 2020, 13:59
Fabien updated this revision to Diff 26479.Dec 21 2020, 14:40

Update comment. TIL you can add comments on blocks and not only a single line with phab

Harbormaster completed remote builds in B14484: Diff 26479.Dec 21 2020, 15:02
majcosta accepted this revision.Dec 21 2020, 15:28
This revision is now accepted and ready to land.Dec 21 2020, 15:28
Closed by commit rABC5c39c9d8f014: [net/refactor] Rework ThreadOpenConnections logic (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by Fabien). · Explain WhyDec 21 2020, 15:58
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC5c39c9d8f014: [net/refactor] Rework ThreadOpenConnections logic.

Revision Contents
Changeset List

PathSize
src/
23 lines
40 lines

Diff 26479

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...