Differential D8732

[test] Add test for NODE_COMPACT_FILTER.
ClosedPublic
Actions

Authored by Fabien on Dec 21 2020, 15:31.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCaa5b13600c21: [test] Add test for NODE_COMPACT_FILTER.

Summary

Test that a node configured to serve compact filters will signal
NODE_COMPACT_FILTER service bit.

Completes backport (3/3) of core PR19070:
https://github.com/bitcoin/bitcoin/pull/19070/commits/f5c003d3ead182335252558c5c6c9b9ca8968065

Depends on D8731.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19070_p3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14490
Build 28944: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 28943: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 21 2020, 15:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2020, 15:31

Fabien requested review of this revision.Dec 21 2020, 15:31

teamcity edited the summary of this revision. (Show Details)Dec 21 2020, 15:31

Harbormaster completed remote builds in B14487: Diff 26482.Dec 21 2020, 16:00

Rebase

Harbormaster completed remote builds in B14490: Diff 26505.Dec 21 2020, 16:55

PiRK accepted this revision.Dec 21 2020, 17:15

This revision is now accepted and ready to land.Dec 21 2020, 17:15

Closed by commit rABCaa5b13600c21: [test] Add test for NODE_COMPACT_FILTER. (authored by jimpo, committed by Fabien). · Explain WhyDec 21 2020, 20:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCaa5b13600c21: [test] Add test for NODE_COMPACT_FILTER..

Fabien mentioned this in T589: BIP157 & BIP158 backports.Dec 23 2020, 09:48

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_blockfilters.py

17 lines

test_framework/

messages.py

1 line

Diff 26505

View Options

test/functional/p2p_blockfilters.py