Page MenuHomePhabricator
Differential D1010

Remove redundant CChainParams from ConnectBlock
ClosedPublic
Actions

Authored by jasonbcox on Jan 22 2018, 05:17.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8c9015067129: Remove redundant CChainParams from ConnectBlock
rABC8c9015067129: Remove redundant CChainParams from ConnectBlock
Summary

T166: Cleanup redudant code since config.GetChainParams() can be used in place of the CChainParams parameter.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cblock
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/validation.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 1749
Build 1749: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 22 2018, 05:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2018, 05:17
teamcity added a subscriber: teamcity.Jan 22 2018, 05:18

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 22 2018, 05:36

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix requested changes to this revision.Jan 22 2018, 14:10
deadalnix added inline comments.
src/validation.cpp
1904 ↗(On Diff #2672)

Sounds like you have a lot of GetChainParams in there. You should probably assign this to a local variable.

This revision now requires changes to proceed.Jan 22 2018, 14:10
jasonbcox updated this revision to Diff 2710.Jan 23 2018, 19:24
jasonbcox marked an inline comment as done.

Added local variable for chainParams

Harbormaster completed remote builds in B1745: Diff 2710.Jan 23 2018, 19:24
teamcity added a comment.Jan 23 2018, 19:26

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Jan 23 2018, 19:48

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix requested changes to this revision.Jan 23 2018, 21:41
deadalnix added inline comments.
src/validation.cpp
1904 ↗(On Diff #2710)
const Consensus::Params &consensusParams = config.GetChainParams().GetConsensus();
This revision now requires changes to proceed.Jan 23 2018, 21:41
jasonbcox updated this revision to Diff 2714.Jan 23 2018, 21:41

I liked Matias's solution to this better because it's cleaner (see D1028).

teamcity added a comment.Jan 23 2018, 21:42

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B1749: Diff 2714.Jan 23 2018, 21:43
jasonbcox marked an inline comment as done.Jan 23 2018, 21:43
jasonbcox added inline comments.
src/validation.cpp
1904 ↗(On Diff #2710)

Updated my diff in the same time that you commented on this. I saw it in Matias's diff and liked it better. :)

deadalnix accepted this revision.Jan 23 2018, 21:46
This revision is now accepted and ready to land.Jan 23 2018, 21:46
teamcity added a comment.Jan 23 2018, 22:01

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Closed by commit rABC8c9015067129: Remove redundant CChainParams from ConnectBlock (authored by jasonbcox). · Explain WhyJan 24 2018, 00:15
This revision was automatically updated to reflect the committed changes.
jasonbcox marked an inline comment as done.

Revision Contents
Changeset List

PathSize
src/
46 lines

Diff 2714

View Options

src/validation.cpp

Loading...