Page MenuHomePhabricator
Differential D1056

Add safe flag to listunspent result
ClosedPublic
Actions

Authored by deadalnix on Feb 2 2018, 14:18.

Details

Reviewers
matiu
Group Reviewers
Restricted Project
Commits
rSTAGING9b1a6ce55464: Add safe flag to listunspent result
rABC9b1a6ce55464: Add safe flag to listunspent result
Summary

Backport core's PR9830

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
safelistunspent
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1798
Build 1798: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 2 2018, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2018, 14:18
Harbormaster completed remote builds in B1792: Diff 2793.Feb 2 2018, 14:18
teamcity added a subscriber: teamcity.Feb 2 2018, 14:20

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

matiu added a subscriber: matiu.Feb 2 2018, 14:38
matiu added inline comments.
src/wallet/rpcwallet.cpp
3117 ↗(On Diff #2793)

Maybe we should remove "and unconfirmed replacement transactions"

src/wallet/wallet.cpp
2304 ↗(On Diff #2793)

remove && pcoin->mapValue.count("replaced_by_txid")

src/wallet/wallet.h
475 ↗(On Diff #2793)

remove "and unconfirmed replacement transactions"

teamcity added a comment.Feb 2 2018, 14:39

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added a child revision: D1058: [wallet] [refactor] Simplify getbalance implementation.Feb 2 2018, 15:44
deadalnix added inline comments.Feb 2 2018, 23:59
src/wallet/wallet.cpp
2304 ↗(On Diff #2793)

The comment just above it explain why it is still there.

deadalnix updated this revision to Diff 2803.Feb 3 2018, 00:01

Address comments

Harbormaster completed remote builds in B1798: Diff 2803.Feb 3 2018, 00:01
teamcity added a comment.Feb 3 2018, 00:03

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Feb 3 2018, 00:22

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

matiu accepted this revision.Feb 3 2018, 00:25
This revision is now accepted and ready to land.Feb 3 2018, 00:25
Closed by commit rABC9b1a6ce55464: Add safe flag to listunspent result (authored by NicolasDorier <nicolas.dorier@gmail.com>, committed by deadalnix). · Explain WhyFeb 3 2018, 00:28
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
bench/
3 lines
qt/
15 lines
wallet/
35 lines
test/
3 lines
17 lines
18 lines

Diff 2803

View Options

src/bench/coin_selection.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...