Details

Reviewers

PiRK
Mengerian

Group Reviewers

Restricted Project

Commits

Summary

This RPC makes it possible to build a delegation for a proof and stack
up delegation levels.

Test Plan

./test/functional/test_runner.py abc_rpc_avalancheproof

Diff Detail

Repository

rABC Bitcoin ABC

Branch

build_delegation_rpc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15419
Build 30759: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 30758: arc lint + arc unit

Fabien requested review of this revision.Mar 26 2021, 15:22

Rebase + nits

Add missing argument names in the RPC binding table

Code LGTM. I added an inline comment regarding the RPCHelp, but as I'm not 100% sure about my english I'm not blocking on it.

src/rpc/avalanche.cpp
221	I would change this to "The public key to delegate the proof to." Or "The public key to which to* delegate the proof."*

This revision is now accepted and ready to land.Mar 29 2021, 10:49

Rebase

Just some minor comments.

src/rpc/avalanche.cpp
224 ↗	(On Diff #28043)	I find this a bit confusing to read, since the output is also a delegation.... Maybe some words to distinguish it like "delegation on level up" or "parent delegation" or similar.
275 ↗	(On Diff #28043)	Can this error have a different message than the previous one?

src/rpc/avalanche.cpp
275 ↗	(On Diff #28043)	Sure, but please not that the error is unreachable for now (the previous checks would have fail already).

Update the doc, fix the example, use a different error message

Looks pretty good, I added some more minor wording nits though.

src/rpc/avalanche.cpp
219 ↗	(On Diff #28052)	Maybe something like this: "The private key in base58-encoding. This private key must match If a parent delegation (if supplied), or the proof master public key."
226 ↗	(On Diff #28052)	Minor nit: I'd put the comment about the private key with the private key item, rather than here, since it can also apply to the Proof master public key.