Paths

Table of Contentst

Remove excess GetTransactionSize() helper method.
ClosedPublic
Actions

Authored by schancel on Feb 9 2018, 21:49.

Details

Reviewers

deadalnix
jasonbcox
matiu

Group Reviewers

Restricted Project

Commits

rSTAGING63705c3008b4: Remove excess GetTransactionSize() helper method.
rABC63705c3008b4: Remove excess GetTransactionSize() helper method.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

TxSize

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1819
Build 1831: Bitcoin ABC Buildbot (legacy)
Build 1830: arc lint + arc unit

Event Timeline

schancel created this revision.Feb 9 2018, 21:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2018, 21:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B1819: Diff 2834.Feb 9 2018, 23:13

jasonbcox accepted this revision.Feb 10 2018, 00:23

This revision is now accepted and ready to land.Feb 10 2018, 00:23

deadalnix added inline comments.Feb 15 2018, 05:31

src/qt/walletmodeltransaction.cpp
32	This creates a copy.

Closed by commit rABC63705c3008b4: Remove excess GetTransactionSize() helper method. (authored by schancel). · Explain WhyFeb 17 2018, 05:21

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

bench/

mempool_eviction.cpp

2 lines

net_processing.cpp

2 lines

policy/

policy.cpp

2 lines

primitives/

transaction.h

3 lines

transaction.cpp

8 lines

qt/

walletmodeltransaction.cpp

4 lines

test/

mempool_tests.cpp

13 lines

policyestimator_tests.cpp

2 lines

txmempool.cpp

2 lines

wallet/

wallet.cpp

4 lines

Diff 2834

View Options

src/bench/mempool_eviction.cpp

View Options

src/net_processing.cpp

View Options

src/policy/policy.cpp

View Options

src/primitives/transaction.h

View Options

src/primitives/transaction.cpp

View Options

src/qt/walletmodeltransaction.cpp

View Options

src/test/mempool_tests.cpp

View Options

src/test/policyestimator_tests.cpp

View Options

src/txmempool.cpp

View Options

Remove excess GetTransactionSize() helper method.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2834

src/bench/mempool_eviction.cpp

src/net_processing.cpp

src/policy/policy.cpp

src/primitives/transaction.h

src/primitives/transaction.cpp

src/qt/walletmodeltransaction.cpp

src/test/mempool_tests.cpp

src/test/policyestimator_tests.cpp

src/txmempool.cpp

src/wallet/wallet.cpp

Remove excess GetTransactionSize() helper method.
ClosedPublic
Actions

Revision Contents
Changeset List