-enableavalanche does not imply that the service flag is set (since D9422).
The code is simple enough to not require a comment.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rABC1477b37ad2cc: remove misleading comment
NA
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- misleading_comment
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 15653 Build 31218: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy Build 31217: arc lint + arc unit
Event Timeline
src/net_processing.cpp | ||
---|---|---|
2744 | This whole block doesn't make sense. How are you supposed to get an avaresponse if you have not polled? All that this achieve is preventing detection of peer sending invalid response during IBD. How is that an improvement? About poll, why ignore and leave the peer hanging? Why not just answer that you don't know for every item requested? In fact, this is already what is happening with blocks, and that is the only thing we poll for today. I know you didn't introduce this, but this keeps being modified and the problem remains. |
This comment was removed by Mengerian.