Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCc2d8667339c4: [avalanche] Add a LimitedProofId::computeProofId method

Summary

The piece of proof.cpp that computes the proodif from the limited id and
from the master key will be needed when we verify that a delegation
matches a given proof. This adds a method to LimitedProofId to do the
computation.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15848
Build 31596: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 31595: arc lint + arc unit

Event Timeline

PiRK created this revision.May 27 2021, 13:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2021, 13:44

PiRK requested review of this revision.May 27 2021, 13:44

Harbormaster completed remote builds in B15829: Diff 28639.May 27 2021, 13:57

deadalnix requested changes to this revision.May 27 2021, 13:59

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/avalanche/proofid.h
32 ↗	(On Diff #28639)	This takes a LimitedProofId has argument, but not a ProofId, so why is it a static method in ProofId rather than a method of LimitedProofId?