rpc: remove deprecated getaddressinfo fields
ClosedPublic
Actions

Authored by PiRK on Jun 2 2021, 14:21.

Details

Reviewers

majcosta
Mengerian

Group Reviewers

Restricted Project

Commits

rABC5f4b8a11f74d: rpc: remove deprecated getaddressinfo fields

Summary

rpc: remove deprecated getaddressinfo label field

rpc: remove deprecated getaddressinfo labels: purpose

rpc: getaddressinfo RPCResult fixup

doc: release note for rpc getaddressinfo removals

This is a backport of core#19200

Depends on D9609

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19200

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15899
Build 31698: Build Diff	build-without-wallet · build-clang · build-diff · build-debug · build-clang-tidy · lint-circular-dependencies
Build 31697: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 2 2021, 14:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 2 2021, 14:21

PiRK requested review of this revision.Jun 2 2021, 14:21

Harbormaster completed remote builds in B15886: Diff 28723.Jun 2 2021, 15:50

majcosta added a subscriber: majcosta.Jun 2 2021, 17:44

green, just as long as you rebase on top of D9609 after it lands :)

This revision is now accepted and ready to land.Jun 2 2021, 17:48

remove the empty release-notes-19200.md

There's something strange going on with the release notes.

For one thing, the old release notes should be moved over in a separate Diff. Looks like they were just deleted, and an empty file was created (doc/release-notes-19200.md). This filename is wrong for our repo, the old release notes should have been copied over to doc/release-notes-0.23.4.md in a separate previous Diff.

Also, for some reason the Description doesn't have a clickable link to the orginal Core PR https://github.com/bitcoin/bitcoin/pull/19200

This revision now requires changes to proceed.Jun 2 2021, 17:53

Harbormaster completed remote builds in B15888: Diff 28728.Jun 2 2021, 18:04