Page MenuHomePhabricator
Differential D9736

[core#19011 3/3] Reduce cs_main lock accumulation during GUI startup
ClosedPublic
Actions

Authored by PiRK on Jul 5 2021, 07:58.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCfaf4a486a6ea: [core#19011 3/3] Reduce cs_main lock accumulation during GUI startup
Summary

PR description:

During the GUI startup, there is currently an accumulation of cs_main locks due to setting initial chain state values at multiple locations (in the GUI main thread).

This PR tries to cache the initial chain state (tip height, tip time, best header, etc.) short after loading the blockindex.

The cached values are then used instead of fetching them again (and thus locking cs_main) during setting the client model.

This should fix the initial GUI blocking often experienced during or short after the splashscreen.

This concludes backport of core#19011 [4/4]
https://github.com/bitcoin/bitcoin/pull/19011/commits/386ec192a57b76492125d691ceda1b4aa832312e

Depends on D9735
Depends on D9737

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Jul 5 2021, 07:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2021, 07:58
PiRK requested review of this revision.Jul 5 2021, 07:58
teamcity edited the summary of this revision. (Show Details)Jul 5 2021, 07:58
PiRK added inline comments.Jul 5 2021, 08:14
src/qt/bitcoingui.cpp
1225

This and the following changes to this file is the linter's work

Harbormaster completed remote builds in B16105: Diff 29060.Jul 5 2021, 08:17
PiRK planned changes to this revision.Jul 5 2021, 08:19

It is better to backport core#19104 for this one

PiRK updated this revision to Diff 29062.Jul 5 2021, 08:41
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D9737: [core#19104] gui, refactor: Register Qt meta types in application constructor.

rebase on D9737, fix RegisterMetaTypes

Harbormaster completed remote builds in B16107: Diff 29062.Jul 5 2021, 09:00
Fabien added a subscriber: Fabien.Jul 5 2021, 15:12
Fabien added inline comments.
src/qt/bitcoingui.cpp
1223 ↗(On Diff #29062)

There is something weird with your linter, mine is reverting the changes

PiRK updated this revision to Diff 29067.EditedJul 5 2021, 16:05

downgrade clang-format from version 12 to 10

This undoes the unrelated changes. clang-format-8 has been obsoleted in the latest ubuntu version and in the LLVM install script.

Harbormaster completed remote builds in B16112: Diff 29067.Jul 5 2021, 16:17
majcosta accepted this revision.Jul 5 2021, 19:02
This revision is now accepted and ready to land.Jul 5 2021, 19:02
Closed by commit rABCfaf4a486a6ea: [core#19011 3/3] Reduce cs_main lock accumulation during GUI startup (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by PiRK). · Explain WhyJul 6 2021, 07:17
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCfaf4a486a6ea: [core#19011 3/3] Reduce cs_main lock accumulation during GUI startup.

Revision Contents
Changeset List

PathSize
src/
qt/
13 lines
14 lines
4 lines
32 lines
test/
2 lines

Diff 29060

View Options

src/qt/bitcoin.h

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/test/apptests.cpp

Loading...