Page MenuHomePhabricator
Differential D9772

[core#19724 3/9][refactor] Restructure logic to check for addr relay.
ClosedPublic
Actions

Authored by PiRK on Jul 12 2021, 15:55.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC6ad16ebd6d08: [core#19724 3/9][refactor] Restructure logic to check for addr relay.
Summary

We previously identified if we relay addresses to the connection by checking
for the existence of the m_addr_known data structure. With this commit, we
answer this question based on the connection type.

IsAddrRelayPeer() checked for the existence of the m_addr_known

This is a backport of core#19724 [3/9]
https://github.com/bitcoin/bitcoin/pull/19724/commits/dff16b184b1428a068d144e5e4dde7595b4729c0

Depends on D9771

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Jul 12 2021, 15:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2021, 15:55
PiRK requested review of this revision.Jul 12 2021, 15:55
teamcity edited the summary of this revision. (Show Details)Jul 12 2021, 15:55
PiRK added a child revision: D9773: [core#19724 4/9][doc] Explain address handling logic in process messages.Jul 12 2021, 15:57
Harbormaster completed remote builds in B16159: Diff 29146.Jul 12 2021, 16:16
majcosta accepted this revision.Jul 12 2021, 18:17
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/net_processing.cpp
2976 ↗(On Diff #29146)

remove

This revision is now accepted and ready to land.Jul 12 2021, 18:17
PiRK updated this revision to Diff 29153.Jul 12 2021, 18:38

remove accidental blank line:

Harbormaster completed remote builds in B16166: Diff 29153.Jul 12 2021, 18:52
Closed by commit rABC6ad16ebd6d08: [core#19724 3/9][refactor] Restructure logic to check for addr relay. (authored by Amiti Uttarwar <amiti@uttarwar.org>, committed by PiRK). · Explain WhyJul 13 2021, 14:28
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC6ad16ebd6d08: [core#19724 3/9][refactor] Restructure logic to check for addr relay..

Revision Contents
Changeset List

PathSize
src/
7 lines
3 lines
14 lines
test/
fuzz/
2 lines

Diff 29153

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/fuzz/net.cpp

Loading...