Page MenuHomePhabricator
Differential D9972

test: Add test for conflicted tx notifications
ClosedPublic
Actions

Authored by PiRK on Aug 30 2021, 07:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2f45cfea78bf: test: Add test for conflicted tx notifications
Summary

Add a couple of test for wallet notifications.

Backport notes:

  • The original PR dealt with conflicting transactions due to RBF trickery, which is not possible on the eCash blockchain. So the test is different, we simply create conflicting transactions while the nodes are disconnected.
  • In the original PR, the test for conflicting transactions does not work correctly. We do not observe the same bug. There is a notification for the conflicting transaction, as expected.

This is a backport of core#18878

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 30 2021, 07:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 30 2021, 07:01
PiRK requested review of this revision.Aug 30 2021, 07:01
teamcity edited the summary of this revision. (Show Details)Aug 30 2021, 07:01
PiRK added a comment.Aug 30 2021, 07:03

This was supposed to update D9961. I don't know why it created a new diff.

It is D9961, with the test update from D9962 included, to test conflicting transactions.

PiRK mentioned this in D9961: test: Add test for tx notifications.Aug 30 2021, 07:04
Harbormaster completed remote builds in B16455: Diff 29630.Aug 30 2021, 07:15
PiRK added a child revision: D9962: wallet: Minimal fix to restore conflicted transaction notifications.Aug 30 2021, 07:16
Fabien accepted this revision.Aug 30 2021, 08:58
This revision is now accepted and ready to land.Aug 30 2021, 08:58
Closed by commit rABC2f45cfea78bf: test: Add test for conflicted tx notifications (authored by Russell Yanofsky <russ@yanofsky.org>, committed by PiRK). · Explain WhyAug 30 2021, 11:55
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2f45cfea78bf: test: Add test for conflicted tx notifications.
PiRK mentioned this in D9962: wallet: Minimal fix to restore conflicted transaction notifications.Aug 30 2021, 14:15
PiRK mentioned this in rABC250a0d5b2569: wallet: Minimal fix to restore conflicted transaction notifications.Aug 30 2021, 16:33
Fabien mentioned this in D9997: Fix rebase issue that introduced a linter error.Aug 31 2021, 16:30
Fabien mentioned this in rABC9380ed5cb5c6: Fix rebase issue that introduced a linter error.Sep 1 2021, 06:31

Revision Contents
Changeset List

PathSize
test/
functional/
73 lines

Diff 29639

View Options

test/functional/feature_notifications.py

Loading...