Page MenuHomePhabricator
Differential D10148

rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump)
ClosedPublic
Actions

Authored by PiRK on Sep 17 2021, 14:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC72a4597820c7: rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump)
Summary

This concludes backport of core#19717 [4/4]
https://github.com/bitcoin/bitcoin/pull/19717/commits/fa3d9ce3254882c545d700990fe8e9a678f31eed

Depends on D10147, D10149 and D10159

Note: the forward declaration of RPC functions in rpcwallet.cpp don't seem to exist in Bitcoin ABC, and the ones in wallet_tests.cpp were in rpcdump.h (see D45)

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Sep 17 2021, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2021, 14:18
PiRK requested review of this revision.Sep 17 2021, 14:18
teamcity edited the summary of this revision. (Show Details)Sep 17 2021, 14:18
PiRK edited the summary of this revision. (Show Details)Sep 17 2021, 14:19
PiRK added a parent revision: D10147: rpc: Assert that RPCArg names are equal to CRPCCommand ones (zmq).
Harbormaster completed remote builds in B16694: Diff 30029.Sep 17 2021, 14:43
PiRK added a comment.Sep 17 2021, 15:08

needs rebasing onto D10149 to get rid of the need to const_cast

PiRK updated this revision to Diff 30035.Sep 17 2021, 15:53
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D10149: Make all CRPCCommand actors take a const Config &.

rebase on D10149, use const Config &, don't use const_cast

Harbormaster completed remote builds in B16700: Diff 30035.Sep 17 2021, 16:18
Fabien requested changes to this revision.Sep 19 2021, 05:25
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/rpcdump.cpp
1942

Fix the layout

2368

Dito

This revision now requires changes to proceed.Sep 19 2021, 05:25
PiRK updated this revision to Diff 30049.Sep 19 2021, 10:04

fix layout of error message
Factor the two very similar error messages.

Harbormaster completed remote builds in B16708: Diff 30049.Sep 19 2021, 10:18
Fabien requested changes to this revision.Sep 20 2021, 07:03

OK for the refactor but please make it its own diff

src/wallet/rpcdump.cpp
1641 ↗(On Diff #30049)

Don't copy for no reason

This revision now requires changes to proceed.Sep 20 2021, 07:03
PiRK mentioned this in D10159: factor two very similar error messages.Sep 20 2021, 08:01
PiRK updated this revision to Diff 30059.Sep 20 2021, 08:07
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D10159: factor two very similar error messages.

rebase on D10159

Harbormaster completed remote builds in B16715: Diff 30059.Sep 20 2021, 08:09
teamcity added a comment.Sep 20 2021, 08:09
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[341/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[342/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[343/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[344/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[345/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[346/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[347/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[348/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[349/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[350/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[351/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[352/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[353/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[354/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[355/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[356/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[357/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[358/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[359/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[360/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[361/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[362/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[363/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[364/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[365/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[366/509] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[367/509] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[368/509] Linking C static library src/secp256k1/libsecp256k1.a
[369/509] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[370/509] Linking CXX static library src/libbitcoinconsensus.a
[371/509] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[372/509] Linking C executable src/secp256k1/internal-bench
[373/509] Linking C executable src/secp256k1/recover-bench
[374/509] Linking C executable src/secp256k1/sign-bench
[375/509] Linking C executable src/secp256k1/ecmult-bench
[376/509] Linking C executable src/secp256k1/verify-bench
[377/509] Linking CXX static library src/libscript.a
[378/509] Linking CXX static library src/libcommon.a
[379/509] Linking CXX shared library src/libbitcoinconsensus.so.0.24.2
[380/509] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[381/509] Linking CXX executable src/bitcoin-cli
[382/509] Linking CXX executable src/bitcoin-tx
[383/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o 
/usr/bin/ccache /usr/bin/clang++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -c ../../src/wallet/rpcdump.cpp
../../src/wallet/rpcdump.cpp:1950:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
}
^
1 error generated.
[384/509] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[385/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Sep 20 2021, 08:10
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[342/509] Linking C static library src/secp256k1/libsecp256k1.a
[343/509] Linking CXX static library src/libbitcoinconsensus.a
[344/509] Linking C executable src/secp256k1/ecmult-bench
[345/509] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[346/509] Linking C executable src/secp256k1/internal-bench
[347/509] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[348/509] Linking C executable src/secp256k1/sign-bench
[349/509] Linking C executable src/secp256k1/verify-bench
[350/509] Linking C executable src/secp256k1/recover-bench
[351/509] Linking CXX static library src/libscript.a
[352/509] Installing component secp256k1
-- Install configuration: "Debug"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[353/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[354/509] Linking CXX static library src/libcommon.a
[355/509] Linking CXX shared library src/libbitcoinconsensus.so.0.24.2
[356/509] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[357/509] Linking CXX executable src/bitcoin-cli
[358/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[359/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[360/509] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[361/509] Linking CXX executable src/bitcoin-tx
[362/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[363/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[364/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[365/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[366/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[367/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[368/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[369/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[370/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[371/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[372/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[373/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[374/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[375/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[376/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[377/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[378/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[379/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[380/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[381/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[382/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[383/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -O0 -fPIC -fvisibility=hidden   -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -c ../../src/wallet/rpcdump.cpp
../../src/wallet/rpcdump.cpp: In function ‘UniValue importmulti(const Config&, const JSONRPCRequest&)’:
../../src/wallet/rpcdump.cpp:1950:1: error: no return statement in function returning non-void [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors
[384/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[385/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Sep 20 2021, 08:10
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[341/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[342/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[343/509] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[344/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[345/509] Linking CXX static library src/libbitcoinconsensus.a
[346/509] Linking CXX static library src/libscript.a
[347/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[348/509] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[349/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[350/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[351/509] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[352/509] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[353/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[354/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[355/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[356/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[357/509] Linking CXX static library src/libcommon.a
[358/509] Linking CXX shared library src/libbitcoinconsensus.so.0.24.2
[359/509] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[360/509] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[361/509] Linking CXX executable src/bitcoin-cli
[362/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[363/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[364/509] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[365/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[366/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[367/509] Linking CXX executable src/bitcoin-tx
[368/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[369/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[370/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[371/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[372/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[373/509] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[374/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[375/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[376/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[377/509] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[378/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[379/509] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[380/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[381/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[382/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[383/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -c ../../src/wallet/rpcdump.cpp
../../src/wallet/rpcdump.cpp: In function ‘UniValue importmulti(const Config&, const JSONRPCRequest&)’:
../../src/wallet/rpcdump.cpp:1950:1: error: no return statement in function returning non-void [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors
[384/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[385/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK updated this revision to Diff 30061.Sep 20 2021, 08:12
PiRK edited the summary of this revision. (Show Details)

rebase again after a minor change in D10159

Fabien requested changes to this revision.Sep 20 2021, 08:12

missing a return statement

This revision now requires changes to proceed.Sep 20 2021, 08:12
teamcity added a comment.Sep 20 2021, 08:15
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

OK
[164/445] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[165/445] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/parse_name_tests.cpp.o
[166/445] Automatic MOC for target test_bitcoin-qt
[167/445] Test Bitcoin utilities...
[168/445] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[169/445] pow: testing aserti32d_tests
[170/445] Running utility command for check-pow-aserti32d_tests
[171/445] Running pow test suite
PASSED: pow test suite
[172/445] Linking CXX executable src/seeder/test/test-seeder
[173/445] seeder: testing write_name_tests
[174/445] Running utility command for check-seeder-write_name_tests
[175/445] seeder: testing message_writer_tests
[176/445] Running utility command for check-seeder-message_writer_tests
[177/445] seeder: testing p2p_messaging_tests
[178/445] Running utility command for check-seeder-p2p_messaging_tests
[179/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o
[180/445] seeder: testing parse_name_tests
[181/445] Running utility command for check-seeder-parse_name_tests
[182/445] Running seeder test suite
PASSED: seeder test suite
[183/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/scriptpubkeyman_tests.cpp.o
[184/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o
[185/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[186/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
[187/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
[188/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[189/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[190/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[191/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[192/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
[193/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[194/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[195/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[196/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[197/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[198/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[199/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[200/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[201/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[202/445] Linking CXX executable src/qt/test/test_bitcoin-qt
[203/445] bitcoin-qt: testing test_bitcoin-qt
[204/445] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[205/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
[206/445] Linking CXX executable src/test/test_bitcoin
FAILED: src/test/test_bitcoin 
: && /usr/bin/clang++  -g -O2  -fuse-ld=lld -Wl,-z,relro -Wl,-z,now -fPIE -pie src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o src/test/CMakeFiles/testutil.dir/util/logging.cpp.o src/test/CMakeFiles/testutil.dir/util/mining.cpp.o src/test/CMakeFiles/testutil.dir/util/net.cpp.o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o src/test/CMakeFiles/testutil.dir/util/str.cpp.o src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o src/test/CMakeFiles/test_bitcoin.dir/fixture.cpp.o src/test/CMakeFiles/test_bitcoin.dir/jsonutil.cpp.o src/test/CMakeFiles/test_bitcoin.dir/scriptflags.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sigutil.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/init_test_fixture.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_test_fixture.cpp.o src/test/CMakeFiles/test_bitcoin.dir/activation_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/addrman_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/allocator_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/amount_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/arith_uint256_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/base32_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/base58_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/base64_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/bip32_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/bitmanip_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockchain_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockcheck_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockencodings_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockfilter_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockfilter_index_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockindex_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockstatus_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/bloom_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/bswap_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/cashaddr_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/cashaddrenc_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/checkdatasig_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/checkpoints_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/checkqueue_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/coins_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/compilerbug_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/compress_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/config_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/core_io_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/crypto_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/cuckoocache_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/dbwrapper_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/denialofservice_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/descriptor_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/dnsseeds_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/dstencode_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/feerate_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/finalization_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/flatfile_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/fs_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/getarg_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/hash_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/interfaces_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/intmath_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/inv_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/key_io_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/key_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/lcg_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/logging_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/mempool_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/merkle_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/merkleblock_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/monolith_opcodes_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/multisig_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/net_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/netbase_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/op_reversebytes_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/pmt_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/policy_fee_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/policyestimator_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/prevector_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/radix_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/raii_event_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/random_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/rcu_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/ref_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/reverselock_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/rpc_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/rpc_server_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/rwcollection_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sanity_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/scheduler_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/schnorr_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_bitfield_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_commitment_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_p2sh_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_standard_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/scriptnum_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/serialize_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/settings_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sigcache_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sigencoding_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sighash_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sighashtype_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sigcheckcount_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/skiplist_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/streams_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sync_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/timedata_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/torcontrol_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/transaction_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/txindex_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/txrequest_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/txvalidation_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/txvalidationcache_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/uint256_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/undo_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/util_threadnames_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_block_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_chainstate_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_chainstatemanager_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_flush_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validationinterface_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/versionbits_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/work_comparator_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/rpc/test/server_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/db_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/init_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/scriptpubkeyman_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_crypto_tests.cpp.o  -o src/test/test_bitcoin  -Wl,-rpath,/work/abc-ci-builds/build-clang-tidy/src:  /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a  /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so  src/librpcclient.a  src/libbitcoinconsensus.so.0.24.2  src/libserver.a  src/leveldb/libleveldb.a  src/leveldb/libleveldb-sse4.2.a  src/leveldb/libmemenv.a  /usr/lib/x86_64-linux-gnu/libevent_pthreads.so  /usr/lib/x86_64-linux-gnu/libminiupnpc.so  src/wallet/libwallet.a  /usr/lib/x86_64-linux-gnu/libdb_cxx.so  src/zmq/libzmq.a  /usr/lib/x86_64-linux-gnu/libzmq.so  src/libbitcoinconsensus.a  src/libscript.a  src/libcommon.a  src/libbitcoinconsensus.a  src/libscript.a  src/libcommon.a  src/libutil.a  src/univalue/libunivalue.a  src/crypto/libcrypto.a  src/crypto/libcrypto_sse4.1.a  src/crypto/libcrypto_avx2.a  src/crypto/libcrypto_shani.a  /usr/lib/x86_64-linux-gnu/libevent.so  /usr/lib/x86_64-linux-gnu/libboost_filesystem.so  /usr/lib/x86_64-linux-gnu/libboost_thread.so  /usr/lib/x86_64-linux-gnu/libboost_chrono.so  /usr/lib/x86_64-linux-gnu/libboost_system.so  /usr/lib/x86_64-linux-gnu/libboost_date_time.so  /usr/lib/x86_64-linux-gnu/libboost_atomic.so  src/secp256k1/libsecp256k1.a  /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a  -lm  -pthread  -ldl && :
ld.lld: error: undefined symbol: importmulti()
>>> referenced by wallet_tests.cpp:242 (../../src/wallet/test/wallet_tests.cpp:242)
>>>               src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o:(wallet_tests::importmulti_rescan::test_method())
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
Harbormaster completed remote builds in B16717: Diff 30061.Sep 20 2021, 08:19
teamcity added a comment.Sep 20 2021, 08:19
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[334/509] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[335/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[336/509] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[337/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[338/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[339/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[340/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[341/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[342/509] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[343/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[344/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[345/509] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[346/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[347/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[348/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[349/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[350/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[351/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[352/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[353/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[354/509] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[355/509] Linking CXX static library src/libutil.a
[356/509] Linking CXX static library src/librpcclient.a
[357/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[358/509] Linking CXX static library src/libbitcoinconsensus.a
[359/509] Linking CXX static library src/libscript.a
[360/509] Linking CXX static library src/libcommon.a
[361/509] Linking CXX shared library src/libbitcoinconsensus.so.0.24.2
[362/509] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[363/509] Linking CXX executable src/bitcoin-cli
[364/509] Linking CXX executable src/bitcoin-tx
[365/509] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[366/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[367/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[368/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[369/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o 
/usr/bin/ccache /usr/bin/clang++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -c ../../src/wallet/rpcdump.cpp
../../src/wallet/rpcdump.cpp:1950:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
}
^
1 error generated.
[370/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[371/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[372/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[373/509] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[374/509] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[375/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[376/509] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[377/509] Linking CXX static library src/zmq/libzmq.a
[378/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[379/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[380/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[381/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[382/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[383/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[384/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[385/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Sep 20 2021, 08:21
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[342/509] Installing component secp256k1
-- Install configuration: "Debug"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[343/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[344/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[345/509] Building CXX object src/CMakeFiles/script.dir/script/sigencoding.cpp.o
[346/509] Linking CXX static library src/libbitcoinconsensus.a
[347/509] Building CXX object src/CMakeFiles/common.dir/networks/abc/checkpoints.cpp.o
[348/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[349/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[350/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[351/509] Building CXX object src/CMakeFiles/common.dir/psbt.cpp.o
[352/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[353/509] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[354/509] Linking C executable src/secp256k1/internal-bench
[355/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[356/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[357/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[358/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[359/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[360/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[361/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[362/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[363/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[364/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[365/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[366/509] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[367/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[368/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[369/509] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[370/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[371/509] Linking CXX static library src/libscript.a
[372/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[373/509] Linking CXX static library src/libcommon.a
[374/509] Linking CXX shared library src/libbitcoinconsensus.so.0.24.2
[375/509] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[376/509] Linking CXX executable src/bitcoin-cli
[377/509] Linking CXX executable src/bitcoin-tx
[378/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[379/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[380/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[381/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[382/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[383/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -O0 -fPIC -fvisibility=hidden   -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -c ../../src/wallet/rpcdump.cpp
../../src/wallet/rpcdump.cpp: In function ‘UniValue importmulti(const Config&, const JSONRPCRequest&)’:
../../src/wallet/rpcdump.cpp:1950:1: error: no return statement in function returning non-void [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors
[384/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[385/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Sep 20 2021, 08:22
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[340/509] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[341/509] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[342/509] Linking C executable src/secp256k1/ecmult-bench
[343/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[344/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[345/509] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[346/509] Linking C executable src/secp256k1/internal-bench
[347/509] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[348/509] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[349/509] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[350/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[351/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[352/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[353/509] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[354/509] Linking CXX static library src/libscript.a
[355/509] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[356/509] Linking CXX static library src/libcommon.a
[357/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[358/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[359/509] Linking CXX shared library src/libbitcoinconsensus.so.0.24.2
[360/509] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[361/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[362/509] Linking CXX executable src/bitcoin-cli
[363/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[364/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[365/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[366/509] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[367/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[368/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[369/509] Linking CXX executable src/bitcoin-tx
[370/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[371/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[372/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[373/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[374/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[375/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[376/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[377/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[378/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[379/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[380/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[381/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[382/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[383/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
FAILED: src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -isystem /usr/include/jemalloc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -MF src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o.d -o src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o -c ../../src/wallet/rpcdump.cpp
../../src/wallet/rpcdump.cpp: In function ‘UniValue importmulti(const Config&, const JSONRPCRequest&)’:
../../src/wallet/rpcdump.cpp:1950:1: error: no return statement in function returning non-void [-Werror=return-type]
 }
 ^
cc1plus: all warnings being treated as errors
[384/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[385/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
teamcity added a comment.Sep 20 2021, 08:23
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

OK
[164/445] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[165/445] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/write_name_tests.cpp.o
[166/445] Automatic MOC for target test_bitcoin-qt
[167/445] Linking CXX executable src/seeder/test/test-seeder
[168/445] seeder: testing write_name_tests
[169/445] Running utility command for check-seeder-write_name_tests
[170/445] seeder: testing message_writer_tests
[171/445] Running utility command for check-seeder-message_writer_tests
[172/445] seeder: testing p2p_messaging_tests
[173/445] Running utility command for check-seeder-p2p_messaging_tests
[174/445] seeder: testing parse_name_tests
[175/445] Running utility command for check-seeder-parse_name_tests
[176/445] Running seeder test suite
PASSED: seeder test suite
[177/445] Test Bitcoin utilities...
[178/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_crypto_tests.cpp.o
[179/445] pow: testing aserti32d_tests
[180/445] Running utility command for check-pow-aserti32d_tests
[181/445] Running pow test suite
PASSED: pow test suite
[182/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/scriptpubkeyman_tests.cpp.o
[183/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o
[184/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[185/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[186/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[187/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o
[188/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
[189/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
[190/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[191/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[192/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
[193/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[194/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[195/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[196/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[197/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[198/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[199/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[200/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[201/445] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[202/445] Linking CXX executable src/qt/test/test_bitcoin-qt
[203/445] bitcoin-qt: testing test_bitcoin-qt
[204/445] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[205/445] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
[206/445] Linking CXX executable src/test/test_bitcoin
FAILED: src/test/test_bitcoin 
: && /usr/bin/clang++  -g -O2  -fuse-ld=lld -Wl,-z,relro -Wl,-z,now -fPIE -pie src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o src/test/CMakeFiles/testutil.dir/util/logging.cpp.o src/test/CMakeFiles/testutil.dir/util/mining.cpp.o src/test/CMakeFiles/testutil.dir/util/net.cpp.o src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o src/test/CMakeFiles/testutil.dir/util/str.cpp.o src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o src/test/CMakeFiles/test_bitcoin.dir/fixture.cpp.o src/test/CMakeFiles/test_bitcoin.dir/jsonutil.cpp.o src/test/CMakeFiles/test_bitcoin.dir/scriptflags.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sigutil.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/init_test_fixture.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_test_fixture.cpp.o src/test/CMakeFiles/test_bitcoin.dir/activation_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/addrman_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/allocator_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/amount_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/arith_uint256_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/base32_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/base58_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/base64_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/bip32_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/bitmanip_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockchain_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockcheck_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockencodings_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockfilter_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockfilter_index_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockindex_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/blockstatus_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/bloom_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/bswap_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/cashaddr_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/cashaddrenc_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/checkdatasig_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/checkpoints_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/checkqueue_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/coins_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/compilerbug_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/compress_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/config_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/core_io_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/crypto_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/cuckoocache_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/dbwrapper_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/denialofservice_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/descriptor_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/dnsseeds_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/dstencode_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/feerate_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/finalization_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/flatfile_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/fs_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/getarg_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/hash_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/interfaces_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/intmath_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/inv_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/key_io_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/key_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/lcg_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/logging_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/mempool_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/merkle_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/merkleblock_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/miner_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/monolith_opcodes_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/multisig_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/net_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/netbase_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/op_reversebytes_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/pmt_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/policy_fee_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/policyestimator_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/prevector_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/radix_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/raii_event_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/random_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/rcu_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/ref_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/reverselock_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/rpc_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/rpc_server_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/rwcollection_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sanity_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/scheduler_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/schnorr_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_bitfield_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_commitment_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_p2sh_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_standard_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/scriptnum_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/serialize_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/settings_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sigcache_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sigencoding_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sighash_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sighashtype_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sigcheckcount_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/skiplist_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/streams_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/sync_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/timedata_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/torcontrol_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/transaction_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/txindex_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/txrequest_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/txvalidation_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/txvalidationcache_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/uint256_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/undo_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/util_threadnames_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_block_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_chainstate_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_chainstatemanager_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_flush_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validation_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/validationinterface_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/versionbits_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/work_comparator_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/rpc/test/server_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/db_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/init_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/scriptpubkeyman_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_crypto_tests.cpp.o  -o src/test/test_bitcoin  -Wl,-rpath,/work/abc-ci-builds/build-clang-tidy/src:  /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a  /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so  src/librpcclient.a  src/libbitcoinconsensus.so.0.24.2  src/libserver.a  src/leveldb/libleveldb.a  src/leveldb/libleveldb-sse4.2.a  src/leveldb/libmemenv.a  /usr/lib/x86_64-linux-gnu/libevent_pthreads.so  /usr/lib/x86_64-linux-gnu/libminiupnpc.so  src/wallet/libwallet.a  /usr/lib/x86_64-linux-gnu/libdb_cxx.so  src/zmq/libzmq.a  /usr/lib/x86_64-linux-gnu/libzmq.so  src/libbitcoinconsensus.a  src/libscript.a  src/libcommon.a  src/libbitcoinconsensus.a  src/libscript.a  src/libcommon.a  src/libutil.a  src/univalue/libunivalue.a  src/crypto/libcrypto.a  src/crypto/libcrypto_sse4.1.a  src/crypto/libcrypto_avx2.a  src/crypto/libcrypto_shani.a  /usr/lib/x86_64-linux-gnu/libevent.so  /usr/lib/x86_64-linux-gnu/libboost_filesystem.so  /usr/lib/x86_64-linux-gnu/libboost_thread.so  /usr/lib/x86_64-linux-gnu/libboost_chrono.so  /usr/lib/x86_64-linux-gnu/libboost_system.so  /usr/lib/x86_64-linux-gnu/libboost_date_time.so  /usr/lib/x86_64-linux-gnu/libboost_atomic.so  src/secp256k1/libsecp256k1.a  /usr/lib/x86_64-linux-gnu/libjemalloc_pic.a  -lm  -pthread  -ldl && :
ld.lld: error: undefined symbol: importmulti()
>>> referenced by wallet_tests.cpp:242 (../../src/wallet/test/wallet_tests.cpp:242)
>>>               src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o:(wallet_tests::importmulti_rescan::test_method())
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
PiRK updated this revision to Diff 30062.Sep 20 2021, 08:30

fix rebase accident

Harbormaster completed remote builds in B16718: Diff 30062.Sep 20 2021, 08:42
Fabien accepted this revision.Sep 20 2021, 08:48
This revision is now accepted and ready to land.Sep 20 2021, 08:48
Closed by commit rABC72a4597820c7: rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump) (authored by PiRK). · Explain WhySep 20 2021, 09:28
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABCe77656ba8140: factor two very similar error messages.
PiRK added a commit: rABC72a4597820c7: rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump).

Revision Contents
Changeset List

PathSize
src/
wallet/
10 lines
1854 lines
test/
6 lines

Diff 30035

View Options

src/wallet/rpcdump.h

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...