Paths

Table of Contentst

Differential D10205

sort python imports in wallet_* functional tests
ClosedPublic
Actions

Authored by PiRK on Sep 27 2021, 08:55.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfb4d8d48ff42: sort python imports in wallet_* functional tests

Summary

This is preparation work to add a new linter that will enforce this new sorting.

The command used was:

isort --profile=black --line-length=79 test/functional/wallet_*

See D10200 for the rationale regarding --profile=black --line-length=79

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16790
Build 33430: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 33429: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 27 2021, 08:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2021, 08:55

PiRK requested review of this revision.Sep 27 2021, 08:55

PiRK added a child revision: D10124: add a linter for python imports.Sep 27 2021, 08:59

Harbormaster completed remote builds in B16790: Diff 30173.Sep 27 2021, 09:33

Fabien accepted this revision.Sep 28 2021, 18:04

This revision is now accepted and ready to land.Sep 28 2021, 18:04

rebase to include recently added wallet_startup.py file

Harbormaster completed remote builds in B16804: Diff 30195.Sep 29 2021, 07:20

Closed by commit rABCfb4d8d48ff42: sort python imports in wallet_* functional tests (authored by PiRK). · Explain WhySep 29 2021, 15:47

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCfb4d8d48ff42: sort python imports in wallet_* functional tests.

Revision Contents
Changeset List

Path

Size

test/

functional/

wallet_address_types.py

7 lines

wallet_backup.py

4 lines

wallet_balance.py

6 lines

wallet_basic.py

2 lines

wallet_coinbase_category.py

4 lines

wallet_create_tx.py

9 lines

wallet_createwallet.py

5 lines

5 lines

5 lines

2 lines

7 lines

2 lines

wallet_import_rescan.py

9 lines

wallet_import_with_label.py

3 lines

wallet_importdescriptors.py

7 lines

wallet_importmulti.py

13 lines

wallet_keypool_topup.py

5 lines

wallet_listtransactions.py

5 lines

wallet_multiwallet.py

4 lines

wallet_reorgsrestore.py

8 lines

wallet_txn_clone.py

9 lines

wallet_watchonly.py

5 lines

Diff 30173

View Options

test/functional/wallet_address_types.py

View Options

test/functional/wallet_backup.py

View Options

test/functional/wallet_balance.py

View Options

test/functional/wallet_basic.py

View Options

test/functional/wallet_coinbase_category.py

View Options

test/functional/wallet_create_tx.py

View Options

test/functional/wallet_createwallet.py

View Options

test/functional/wallet_descriptor.py

View Options

test/functional/wallet_dump.py

View Options

test/functional/wallet_encryption.py

View Options

test/functional/wallet_groups.py

View Options

test/functional/wallet_hd.py

View Options

test/functional/wallet_import_rescan.py

View Options

test/functional/wallet_import_with_label.py

View Options

test/functional/wallet_importdescriptors.py

View Options

test/functional/wallet_importmulti.py

View Options

test/functional/wallet_keypool_topup.py

View Options

test/functional/wallet_listtransactions.py

View Options

test/functional/wallet_multiwallet.py

View Options

test/functional/wallet_reorgsrestore.py

View Options

test/functional/wallet_txn_clone.py

View Options

test/functional/wallet_watchonly.py

sort python imports in wallet_* functional testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30173

test/functional/wallet_address_types.py

test/functional/wallet_backup.py

test/functional/wallet_balance.py

test/functional/wallet_basic.py

test/functional/wallet_coinbase_category.py

test/functional/wallet_create_tx.py

test/functional/wallet_createwallet.py

test/functional/wallet_descriptor.py

test/functional/wallet_dump.py

test/functional/wallet_encryption.py

test/functional/wallet_groups.py

test/functional/wallet_hd.py

test/functional/wallet_import_rescan.py

test/functional/wallet_import_with_label.py

test/functional/wallet_importdescriptors.py

test/functional/wallet_importmulti.py

test/functional/wallet_keypool_topup.py

test/functional/wallet_listtransactions.py

test/functional/wallet_multiwallet.py

test/functional/wallet_reorgsrestore.py

test/functional/wallet_txn_clone.py

test/functional/wallet_watchonly.py

sort python imports in wallet_* functional tests
ClosedPublic
Actions

Revision Contents
Changeset List