Page MenuHomePhabricator
Differential D10207

[avalanche] Don't vote against our own proof in case of a conflict
AbandonedPublic
Actions

Authored by Fabien on Sep 27 2021, 19:07.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Summary

Don't vote for evicting ourself from the network.

Ref T1854.

Depends on D10027.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_dont_vote_against_ourself
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16826
Build 33495: Build Difflint-circular-dependencies · build-without-wallet · build-clang-tidy · build-clang · build-diff · build-debug
Build 33494: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 27 2021, 19:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2021, 19:07
Fabien requested review of this revision.Sep 27 2021, 19:07
Harbormaster completed remote builds in B16796: Diff 30182.Sep 27 2021, 19:22
Fabien updated this revision to Diff 30230.Sep 30 2021, 12:47

Rebase

Harbormaster completed remote builds in B16826: Diff 30230.Sep 30 2021, 12:52
teamcity added a comment.Sep 30 2021, 12:52
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

wallet_listreceivedby.py                | ○ Skipped | 0 s
wallet_listsinceblock.py                | ○ Skipped | 0 s
wallet_listtransactions.py              | ○ Skipped | 0 s
wallet_multiwallet.py                   | ○ Skipped | 0 s
wallet_multiwallet.py --usecli          | ○ Skipped | 0 s
wallet_reorgsrestore.py                 | ○ Skipped | 0 s
wallet_resendwallettransactions.py      | ○ Skipped | 0 s
wallet_startup.py                       | ○ Skipped | 0 s
wallet_txn_clone.py                     | ○ Skipped | 0 s
wallet_txn_clone.py --mineblock         | ○ Skipped | 0 s
wallet_txn_doublespend.py               | ○ Skipped | 0 s
wallet_txn_doublespend.py --mineblock   | ○ Skipped | 0 s
wallet_watchonly.py                     | ○ Skipped | 0 s
wallet_watchonly.py --usecli            | ○ Skipped | 0 s

ALL                                     | ✓ Passed  | 527 s (accumulated) 
Runtime: 114 s

----------------------------------------------------------------------
Ran 8 tests in 0.014s

OK

[24/413] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[26/413] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[112/413] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:540:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[167/413] Running seeder test suite
PASSED: seeder test suite
[172/413] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[173/413] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o
FAILED: src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIE -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o -MF src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o.d -o src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o -c ../../src/avalanche/test/processor_tests.cpp
../../src/avalanche/test/processor_tests.cpp: In static member function ‘static std::optional<avalanche::VoteRecord> avalanche::{anonymous}::AvalancheTest::getVoteForProof(const avalanche::Processor&, const std::shared_ptr<avalanche::Proof>&)’:
../../src/avalanche/test/processor_tests.cpp:49:48: error: ‘const class avalanche::Processor’ has no member named ‘conflicting_proofs’; did you mean ‘conflictingProofHandler’?
             auto conflictingProofsReadView = p.conflicting_proofs.getReadView();
                                                ^~~~~~~~~~~~~~~~~~
                                                conflictingProofHandler
[375/413] Running pow test suite
PASSED: pow test suite
[400/413] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Sep 30 2021, 12:54
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[384/452] bitcoin: testing txvalidationcache_tests
[385/452] bitcoin: testing merkleblock_tests
[386/452] Running utility command for check-bitcoin-txvalidationcache_tests
[387/452] Running utility command for check-bitcoin-merkleblock_tests
[388/452] bitcoin: testing bip32_tests
[389/452] bitcoin: testing scheduler_tests
[390/452] Running utility command for check-bitcoin-bip32_tests
[391/452] Running utility command for check-bitcoin-scheduler_tests
[392/452] bitcoin: testing torcontrol_tests
[393/452] bitcoin: testing sync_tests
[394/452] Running utility command for check-bitcoin-torcontrol_tests
[395/452] bitcoin: testing transaction_tests
[396/452] bitcoin: testing op_reversebytes_tests
[397/452] Running utility command for check-bitcoin-sync_tests
[398/452] Running utility command for check-bitcoin-transaction_tests
[399/452] Running utility command for check-bitcoin-op_reversebytes_tests
[400/452] bitcoin: testing settings_tests
[401/452] bitcoin: testing streams_tests
[402/452] Running utility command for check-bitcoin-settings_tests
[403/452] bitcoin: testing validation_flush_tests
[404/452] Running utility command for check-bitcoin-streams_tests
[405/452] bitcoin: testing timedata_tests
[406/452] bitcoin: testing compilerbug_tests
[407/452] Running utility command for check-bitcoin-validation_flush_tests
[408/452] Running utility command for check-bitcoin-timedata_tests
[409/452] Running utility command for check-bitcoin-compilerbug_tests
[410/452] bitcoin: testing blockcheck_tests
[411/452] Running utility command for check-bitcoin-blockcheck_tests
[412/452] bitcoin: testing checkpoints_tests
[413/452] bitcoin: testing serialize_tests
[414/452] Running utility command for check-bitcoin-checkpoints_tests
[415/452] bitcoin: testing schnorr_tests
[416/452] bitcoin: testing validationinterface_tests
[417/452] Running utility command for check-bitcoin-serialize_tests
[418/452] Running utility command for check-bitcoin-validationinterface_tests
[419/452] Running utility command for check-bitcoin-schnorr_tests
[420/452] bitcoin: testing blockstatus_tests
[421/452] bitcoin: testing cashaddr_tests
[422/452] Running utility command for check-bitcoin-blockstatus_tests
[423/452] Running utility command for check-bitcoin-cashaddr_tests
[424/452] bitcoin: testing wallet_tests
[425/452] bitcoin: testing versionbits_tests
[426/452] Running utility command for check-bitcoin-wallet_tests
[427/452] Running utility command for check-bitcoin-versionbits_tests
[428/452] bitcoin: testing intmath_tests
[429/452] Running utility command for check-bitcoin-intmath_tests
[430/452] bitcoin: testing script_tests
[431/452] bitcoin: testing crypto_tests
[432/452] Running utility command for check-bitcoin-script_tests
[433/452] Running utility command for check-bitcoin-crypto_tests
[434/452] bitcoin: testing monolith_opcodes_tests
[435/452] Running utility command for check-bitcoin-monolith_opcodes_tests
[436/452] bitcoin: testing coinselector_tests
[437/452] Running utility command for check-bitcoin-coinselector_tests
[438/452] bitcoin: testing coins_tests
[439/452] Running utility command for check-bitcoin-coins_tests
[440/452] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Sep 30 2021, 12:56
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[377/445] Running utility command for check-bitcoin-txvalidationcache_tests
[378/445] Running utility command for check-bitcoin-bip32_tests
[379/445] bitcoin: testing sync_tests
[380/445] Running utility command for check-bitcoin-sync_tests
[381/445] bitcoin: testing torcontrol_tests
[382/445] bitcoin: testing op_reversebytes_tests
[383/445] Running utility command for check-bitcoin-torcontrol_tests
[384/445] Running utility command for check-bitcoin-op_reversebytes_tests
[385/445] bitcoin: testing settings_tests
[386/445] Running utility command for check-bitcoin-settings_tests
[387/445] bitcoin: testing timedata_tests
[388/445] bitcoin: testing streams_tests
[389/445] Running utility command for check-bitcoin-timedata_tests
[390/445] Running utility command for check-bitcoin-streams_tests
[391/445] bitcoin: testing validation_flush_tests
[392/445] bitcoin: testing compilerbug_tests
[393/445] Running utility command for check-bitcoin-validation_flush_tests
[394/445] Running utility command for check-bitcoin-compilerbug_tests
[395/445] bitcoin: testing blockcheck_tests
[396/445] bitcoin: testing serialize_tests
[397/445] Running utility command for check-bitcoin-blockcheck_tests
[398/445] Running utility command for check-bitcoin-serialize_tests
[399/445] bitcoin: testing radix_tests
[400/445] bitcoin: testing schnorr_tests
[401/445] bitcoin: testing transaction_tests
[402/445] Running utility command for check-bitcoin-radix_tests
[403/445] Running utility command for check-bitcoin-schnorr_tests
[404/445] bitcoin: testing checkpoints_tests
[405/445] Running utility command for check-bitcoin-transaction_tests
[406/445] bitcoin: testing script_standard_tests
[407/445] bitcoin: testing wallet_tests
[408/445] Running utility command for check-bitcoin-checkpoints_tests
[409/445] bitcoin: testing validationinterface_tests
[410/445] Running utility command for check-bitcoin-wallet_tests
[411/445] Running utility command for check-bitcoin-script_standard_tests
[412/445] Running utility command for check-bitcoin-validationinterface_tests
[413/445] bitcoin: testing blockstatus_tests
[414/445] bitcoin: testing cashaddr_tests
[415/445] Running utility command for check-bitcoin-blockstatus_tests
[416/445] Running utility command for check-bitcoin-cashaddr_tests
[417/445] bitcoin: testing util_tests
[418/445] Running utility command for check-bitcoin-util_tests
[419/445] bitcoin: testing versionbits_tests
[420/445] bitcoin: testing script_tests
[421/445] Running utility command for check-bitcoin-versionbits_tests
[422/445] Running utility command for check-bitcoin-script_tests
[423/445] bitcoin: testing crypto_tests
[424/445] Running utility command for check-bitcoin-crypto_tests
[425/445] bitcoin: testing monolith_opcodes_tests
[426/445] Running utility command for check-bitcoin-monolith_opcodes_tests
[427/445] bitcoin: testing intmath_tests
[428/445] Running utility command for check-bitcoin-intmath_tests
[429/445] bitcoin: testing coinselector_tests
[430/445] Running utility command for check-bitcoin-coinselector_tests
[431/445] bitcoin: testing coins_tests
[432/445] Running utility command for check-bitcoin-coins_tests
[433/445] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
Fabien planned changes to this revision.Sep 30 2021, 12:57

Poor rebase

teamcity added a comment.Sep 30 2021, 12:57
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

wallet_descriptor.py                    | ✓ Passed  | 8 s
wallet_disable.py                       | ✓ Passed  | 1 s
wallet_dump.py                          | ✓ Passed  | 6 s
wallet_encryption.py                    | ✓ Passed  | 5 s
wallet_hd.py                            | ✓ Passed  | 9 s
wallet_import_rescan.py                 | ✓ Passed  | 10 s
wallet_import_with_label.py             | ✓ Passed  | 1 s
wallet_importdescriptors.py             | ✓ Passed  | 7 s
wallet_importmulti.py                   | ✓ Passed  | 6 s
wallet_importprunedfunds.py             | ✓ Passed  | 2 s
wallet_keypool.py                       | ✓ Passed  | 3 s
wallet_keypool_topup.py                 | ✓ Passed  | 4 s
wallet_labels.py                        | ✓ Passed  | 2 s
wallet_listreceivedby.py                | ✓ Passed  | 38 s
wallet_listsinceblock.py                | ✓ Passed  | 7 s
wallet_listtransactions.py              | ✓ Passed  | 9 s
wallet_multiwallet.py                   | ✓ Passed  | 30 s
wallet_multiwallet.py --usecli          | ✓ Passed  | 18 s
wallet_reorgsrestore.py                 | ✓ Passed  | 5 s
wallet_resendwallettransactions.py      | ✓ Passed  | 2 s
wallet_startup.py                       | ✓ Passed  | 3 s
wallet_txn_clone.py                     | ✓ Passed  | 3 s
wallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
wallet_txn_doublespend.py               | ✓ Passed  | 2 s
wallet_txn_doublespend.py --mineblock   | ✓ Passed  | 4 s
wallet_watchonly.py                     | ✓ Passed  | 1 s
wallet_watchonly.py --usecli            | ✓ Passed  | 2 s

ALL                                     | ✓ Passed  | 1486 s (accumulated) 
Runtime: 306 s

----------------------------------------------------------------------
Ran 8 tests in 0.027s

OK

[150/453] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.010s

OK
[151/453] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.016s

OK
[184/453] Running seeder test suite
PASSED: seeder test suite
[413/453] Running pow test suite
PASSED: pow test suite
[418/453] Running secp256k1 test suite
PASSED: secp256k1 test suite
[435/453] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[440/453] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Sep 30 2021, 13:01
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

rpc_preciousblock.py                    | ✓ Passed  | 1 s
rpc_psbt.py                             | ✓ Passed  | 44 s
rpc_rawtransaction.py                   | ✓ Passed  | 13 s
rpc_scantxoutset.py                     | ✓ Passed  | 3 s
rpc_setban.py                           | ✓ Passed  | 2 s
rpc_signmessage.py                      | ✓ Passed  | 1 s
rpc_signrawtransaction.py               | ✓ Passed  | 2 s
rpc_txoutproof.py                       | ✓ Passed  | 2 s
rpc_uptime.py                           | ✓ Passed  | 1 s
rpc_users.py                            | ✓ Passed  | 5 s
rpc_whitelist.py                        | ✓ Passed  | 1 s
tool_wallet.py                          | ✓ Passed  | 4 s
wallet_abandonconflict.py               | ✓ Passed  | 7 s
wallet_address_types.py                 | ✓ Passed  | 14 s
wallet_avoidreuse.py                    | ✓ Passed  | 4 s
wallet_backup.py                        | ✓ Passed  | 22 s
wallet_balance.py                       | ✓ Passed  | 22 s
wallet_basic.py                         | ✓ Passed  | 19 s
wallet_coinbase_category.py             | ✓ Passed  | 1 s
wallet_create_tx.py                     | ✓ Passed  | 5 s
wallet_createwallet.py                  | ✓ Passed  | 2 s
wallet_createwallet.py --usecli         | ✓ Passed  | 3 s
wallet_descriptor.py                    | ✓ Passed  | 6 s
wallet_disable.py                       | ✓ Passed  | 0 s
wallet_dump.py                          | ✓ Passed  | 5 s
wallet_encryption.py                    | ✓ Passed  | 5 s
wallet_hd.py                            | ✓ Passed  | 6 s
wallet_import_rescan.py                 | ✓ Passed  | 4 s
wallet_import_with_label.py             | ✓ Passed  | 1 s
wallet_importdescriptors.py             | ✓ Passed  | 4 s
wallet_importmulti.py                   | ✓ Passed  | 3 s
wallet_importprunedfunds.py             | ✓ Passed  | 1 s
wallet_keypool.py                       | ✓ Passed  | 3 s
wallet_keypool_topup.py                 | ✓ Passed  | 2 s
wallet_labels.py                        | ✓ Passed  | 1 s
wallet_listreceivedby.py                | ✓ Passed  | 16 s
wallet_listsinceblock.py                | ✓ Passed  | 4 s
wallet_listtransactions.py              | ✓ Passed  | 10 s
wallet_multiwallet.py                   | ✓ Passed  | 44 s
wallet_multiwallet.py --usecli          | ✓ Passed  | 11 s
wallet_reorgsrestore.py                 | ✓ Passed  | 3 s
wallet_resendwallettransactions.py      | ✓ Passed  | 4 s
wallet_startup.py                       | ✓ Passed  | 2 s
wallet_txn_clone.py                     | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
wallet_txn_doublespend.py               | ✓ Passed  | 2 s
wallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
wallet_watchonly.py                     | ✓ Passed  | 1 s
wallet_watchonly.py --usecli            | ✓ Passed  | 1 s

ALL                                     | ✓ Passed  | 1002 s (accumulated) 
Runtime: 208 s

----------------------------------------------------------------------
Ran 8 tests in 0.009s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
Fabien updated this revision to Diff 30232.Sep 30 2021, 13:07

Fix the bad rebase

Harbormaster completed remote builds in B16828: Diff 30232.Sep 30 2021, 13:21
Fabien updated this revision to Diff 30268.Oct 1 2021, 12:28

Rebase

Harbormaster completed remote builds in B16856: Diff 30268.Oct 1 2021, 12:31
teamcity added a comment.Oct 1 2021, 12:31
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[388/455] bitcoin: testing validation_flush_tests
[389/455] bitcoin: testing compilerbug_tests
[390/455] Running utility command for check-bitcoin-timedata_tests
[391/455] Running utility command for check-bitcoin-compilerbug_tests
[392/455] Running utility command for check-bitcoin-validation_flush_tests
[393/455] bitcoin: testing checkpoints_tests
[394/455] bitcoin: testing blockcheck_tests
[395/455] bitcoin: testing wallet_tests
[396/455] Running utility command for check-bitcoin-checkpoints_tests
[397/455] Running utility command for check-bitcoin-wallet_tests
[398/455] bitcoin: testing serialize_tests
[399/455] Running utility command for check-bitcoin-blockcheck_tests
[400/455] Running utility command for check-pow-grasberg_tests
[401/455] Running utility command for check-pow-aserti32d_tests
[402/455] bitcoin: testing validationinterface_tests
[403/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[404/455] Running pow test suite
PASSED: pow test suite
[405/455] bitcoin: testing schnorr_tests
[406/455] Running utility command for check-bitcoin-serialize_tests
[407/455] Running utility command for check-bitcoin-validationinterface_tests
[408/455] bitcoin: testing blockstatus_tests
[409/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[410/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[411/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[412/455] Running utility command for check-bitcoin-schnorr_tests
[413/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[414/455] Running utility command for check-bitcoin-blockstatus_tests
[415/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[416/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[417/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[418/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[419/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[420/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[421/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[422/455] bitcoin: testing cashaddr_tests
[423/455] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[424/455] Running utility command for check-bitcoin-cashaddr_tests
[425/455] bitcoin: testing versionbits_tests
[426/455] Running utility command for check-bitcoin-versionbits_tests
[427/455] bitcoin: testing crypto_tests
[428/455] Running utility command for check-bitcoin-crypto_tests
[429/455] Linking CXX executable src/qt/test/test_bitcoin-qt
[430/455] bitcoin: testing script_tests
[431/455] Running utility command for check-bitcoin-script_tests
[432/455] bitcoin: testing monolith_opcodes_tests
[433/455] Running utility command for check-bitcoin-monolith_opcodes_tests
[434/455] secp256k1: testing secp256k1-exhaustive_tests
[435/455] bitcoin-qt: testing test_bitcoin-qt
[436/455] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[437/455] bitcoin: testing coins_tests
[438/455] Running utility command for check-bitcoin-coins_tests
[439/455] Running bitcoin test suite
PASSED: bitcoin test suite
[440/455] secp256k1: testing secp256k1-tests
[441/455] Running secp256k1 test suite
PASSED: secp256k1 test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Oct 1 2021, 12:33
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[380/448] Running utility command for check-bitcoin-txvalidationcache_tests
[381/448] bitcoin: testing op_reversebytes_tests
[382/448] Running utility command for check-bitcoin-op_reversebytes_tests
[383/448] bitcoin: testing streams_tests
[384/448] bitcoin: testing intmath_tests
[385/448] bitcoin: testing settings_tests
[386/448] Running utility command for check-bitcoin-streams_tests
[387/448] bitcoin: testing timedata_tests
[388/448] Running utility command for check-bitcoin-settings_tests
[389/448] Running utility command for check-bitcoin-intmath_tests
[390/448] Running utility command for check-bitcoin-timedata_tests
[391/448] bitcoin: testing serialize_tests
[392/448] bitcoin: testing radix_tests
[393/448] Running utility command for check-bitcoin-serialize_tests
[394/448] bitcoin: testing validation_flush_tests
[395/448] Running utility command for check-bitcoin-radix_tests
[396/448] bitcoin: testing compilerbug_tests
[397/448] Running utility command for check-bitcoin-validation_flush_tests
[398/448] bitcoin: testing checkpoints_tests
[399/448] bitcoin: testing schnorr_tests
[400/448] bitcoin: testing validationinterface_tests
[401/448] Running utility command for check-bitcoin-compilerbug_tests
[402/448] Running utility command for check-bitcoin-checkpoints_tests
[403/448] Running utility command for check-bitcoin-validationinterface_tests
[404/448] Running utility command for check-bitcoin-schnorr_tests
[405/448] Running utility command for check-pow-aserti32d_tests
[406/448] Running pow test suite
PASSED: pow test suite
[407/448] bitcoin: testing script_standard_tests
[408/448] Running utility command for check-bitcoin-script_standard_tests
[409/448] bitcoin: testing blockstatus_tests
[410/448] bitcoin: testing cashaddr_tests
[411/448] Running utility command for check-bitcoin-blockstatus_tests
[412/448] Running utility command for check-bitcoin-cashaddr_tests
[413/448] bitcoin: testing script_tests
[414/448] Running utility command for check-bitcoin-script_tests
[415/448] bitcoin: testing versionbits_tests
[416/448] bitcoin: testing util_tests
[417/448] Running utility command for check-bitcoin-util_tests
[418/448] Running utility command for check-bitcoin-versionbits_tests
[419/448] Linking CXX executable src/qt/test/test_bitcoin-qt
[420/448] bitcoin: testing crypto_tests
[421/448] Running utility command for check-bitcoin-crypto_tests
[422/448] bitcoin: testing blockcheck_tests
[423/448] bitcoin: testing wallet_tests
[424/448] Running utility command for check-bitcoin-blockcheck_tests
[425/448] Running utility command for check-bitcoin-wallet_tests
[426/448] bitcoin: testing monolith_opcodes_tests
[427/448] Running utility command for check-bitcoin-monolith_opcodes_tests
[428/448] bitcoin: testing coinselector_tests
[429/448] Running utility command for check-bitcoin-coinselector_tests
[430/448] bitcoin-qt: testing test_bitcoin-qt
[431/448] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[432/448] bitcoin: testing coins_tests
[433/448] Running utility command for check-bitcoin-coins_tests
[434/448] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Oct 1 2021, 12:34
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

wallet_listsinceblock.py                | ○ Skipped | 0 s
wallet_listtransactions.py              | ○ Skipped | 0 s
wallet_multiwallet.py                   | ○ Skipped | 0 s
wallet_multiwallet.py --usecli          | ○ Skipped | 0 s
wallet_reorgsrestore.py                 | ○ Skipped | 0 s
wallet_resendwallettransactions.py      | ○ Skipped | 0 s
wallet_startup.py                       | ○ Skipped | 0 s
wallet_txn_clone.py                     | ○ Skipped | 0 s
wallet_txn_clone.py --mineblock         | ○ Skipped | 0 s
wallet_txn_doublespend.py               | ○ Skipped | 0 s
wallet_txn_doublespend.py --mineblock   | ○ Skipped | 0 s
wallet_watchonly.py                     | ○ Skipped | 0 s
wallet_watchonly.py --usecli            | ○ Skipped | 0 s

ALL                                     | ✓ Passed  | 494 s (accumulated) 
Runtime: 99 s

----------------------------------------------------------------------
Ran 8 tests in 0.013s

OK

[26/416] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[28/416] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[112/416] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
In file included from /usr/include/boost/test/unit_test.hpp:19,
                 from ../../src/test/script_tests.cpp:30:
../../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
../../src/test/script_tests.cpp:540:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 BOOST_AUTO_TEST_CASE(script_build) {
                      ^~~~~~~~~~~~
[171/416] Running seeder test suite
PASSED: seeder test suite
[172/416] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o
FAILED: src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIE -fvisibility=hidden   -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o -MF src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o.d -o src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o -c ../../src/avalanche/test/processor_tests.cpp
../../src/avalanche/test/processor_tests.cpp:62:55: error: expected class-name before ‘{’ token
         : public PeerManager::ConflictingProofHandler {
                                                       ^
../../src/avalanche/test/processor_tests.cpp:68:9: error: ‘void avalanche::{anonymous}::TestConflictingProofHandler::onConflictingProof(const std::shared_ptr<avalanche::Proof>&, const std::unordered_set<unsigned int>&, bool)’ marked ‘override’, but does not override
         onConflictingProof(const std::shared_ptr<Proof> &proof,
         ^~~~~~~~~~~~~~~~~~
[176/416] Running pow test suite
PASSED: pow test suite
[391/416] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[401/416] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Oct 1 2021, 12:37
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

wallet_importprunedfunds.py             | ✓ Passed  | 2 s
wallet_keypool.py                       | ✓ Passed  | 3 s
wallet_keypool_topup.py                 | ✓ Passed  | 4 s
wallet_labels.py                        | ✓ Passed  | 2 s
wallet_listreceivedby.py                | ✓ Passed  | 9 s
wallet_listsinceblock.py                | ✓ Passed  | 6 s
wallet_listtransactions.py              | ✓ Passed  | 22 s
wallet_multiwallet.py                   | ✓ Passed  | 32 s
wallet_multiwallet.py --usecli          | ✓ Passed  | 17 s
wallet_reorgsrestore.py                 | ✓ Passed  | 4 s
wallet_resendwallettransactions.py      | ✓ Passed  | 6 s
wallet_startup.py                       | ✓ Passed  | 2 s
wallet_txn_clone.py                     | ✓ Passed  | 3 s
wallet_txn_clone.py --mineblock         | ✓ Passed  | 4 s
wallet_txn_doublespend.py               | ✓ Passed  | 2 s
wallet_txn_doublespend.py --mineblock   | ✓ Passed  | 4 s
wallet_watchonly.py                     | ✓ Passed  | 1 s
wallet_watchonly.py --usecli            | ✓ Passed  | 2 s

ALL                                     | ✓ Passed  | 1360 s (accumulated) 
Runtime: 272 s

----------------------------------------------------------------------
Ran 8 tests in 0.030s

OK

[29/456] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
[31/456] cd /work/contrib/devtools/chainparams && /usr/bin/python3.7 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[184/456] Running seeder test suite
PASSED: seeder test suite
[185/456] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o
FAILED: src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DABORT_ON_FAILED_ASSUME -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBOOST_TEST_DYN_LINK -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIE -fvisibility=hidden   -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o -MF src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o.d -o src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o -c ../../src/avalanche/test/processor_tests.cpp
../../src/avalanche/test/processor_tests.cpp:62:55: error: expected class-name before ‘{’ token
         : public PeerManager::ConflictingProofHandler {
                                                       ^
../../src/avalanche/test/processor_tests.cpp:68:9: error: ‘void avalanche::{anonymous}::TestConflictingProofHandler::onConflictingProof(const std::shared_ptr<avalanche::Proof>&, const std::unordered_set<unsigned int>&, bool)’ marked ‘override’, but does not override
         onConflictingProof(const std::shared_ptr<Proof> &proof,
         ^~~~~~~~~~~~~~~~~~
[415/456] Running pow test suite
PASSED: pow test suite
[416/456] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[439/456] Running bitcoin test suite
PASSED: bitcoin test suite
[441/456] Running secp256k1 test suite
PASSED: secp256k1 test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Oct 1 2021, 12:39
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

rpc_preciousblock.py                    | ✓ Passed  | 1 s
rpc_psbt.py                             | ✓ Passed  | 23 s
rpc_rawtransaction.py                   | ✓ Passed  | 13 s
rpc_scantxoutset.py                     | ✓ Passed  | 3 s
rpc_setban.py                           | ✓ Passed  | 2 s
rpc_signmessage.py                      | ✓ Passed  | 1 s
rpc_signrawtransaction.py               | ✓ Passed  | 1 s
rpc_txoutproof.py                       | ✓ Passed  | 2 s
rpc_uptime.py                           | ✓ Passed  | 1 s
rpc_users.py                            | ✓ Passed  | 5 s
rpc_whitelist.py                        | ✓ Passed  | 1 s
tool_wallet.py                          | ✓ Passed  | 4 s
wallet_abandonconflict.py               | ✓ Passed  | 7 s
wallet_address_types.py                 | ✓ Passed  | 12 s
wallet_avoidreuse.py                    | ✓ Passed  | 4 s
wallet_backup.py                        | ✓ Passed  | 27 s
wallet_balance.py                       | ✓ Passed  | 19 s
wallet_basic.py                         | ✓ Passed  | 20 s
wallet_coinbase_category.py             | ✓ Passed  | 1 s
wallet_create_tx.py                     | ✓ Passed  | 5 s
wallet_createwallet.py                  | ✓ Passed  | 2 s
wallet_createwallet.py --usecli         | ✓ Passed  | 3 s
wallet_descriptor.py                    | ✓ Passed  | 6 s
wallet_disable.py                       | ✓ Passed  | 0 s
wallet_dump.py                          | ✓ Passed  | 5 s
wallet_encryption.py                    | ✓ Passed  | 5 s
wallet_hd.py                            | ✓ Passed  | 6 s
wallet_import_rescan.py                 | ✓ Passed  | 5 s
wallet_import_with_label.py             | ✓ Passed  | 1 s
wallet_importdescriptors.py             | ✓ Passed  | 6 s
wallet_importmulti.py                   | ✓ Passed  | 3 s
wallet_importprunedfunds.py             | ✓ Passed  | 2 s
wallet_keypool.py                       | ✓ Passed  | 3 s
wallet_keypool_topup.py                 | ✓ Passed  | 2 s
wallet_labels.py                        | ✓ Passed  | 1 s
wallet_listreceivedby.py                | ✓ Passed  | 9 s
wallet_listsinceblock.py                | ✓ Passed  | 3 s
wallet_listtransactions.py              | ✓ Passed  | 15 s
wallet_multiwallet.py                   | ✓ Passed  | 42 s
wallet_multiwallet.py --usecli          | ✓ Passed  | 14 s
wallet_reorgsrestore.py                 | ✓ Passed  | 3 s
wallet_resendwallettransactions.py      | ✓ Passed  | 4 s
wallet_startup.py                       | ✓ Passed  | 2 s
wallet_txn_clone.py                     | ✓ Passed  | 2 s
wallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
wallet_txn_doublespend.py               | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
wallet_watchonly.py                     | ✓ Passed  | 1 s
wallet_watchonly.py --usecli            | ✓ Passed  | 1 s

ALL                                     | ✓ Passed  | 1011 s (accumulated) 
Runtime: 202 s

----------------------------------------------------------------------
Ran 8 tests in 0.009s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
Fabien updated this revision to Diff 30272.Oct 1 2021, 13:13

I really need to fix my arcanist...

Harbormaster completed remote builds in B16858: Diff 30272.Oct 1 2021, 13:34
deadalnix requested changes to this revision.Oct 1 2021, 13:38
deadalnix added a subscriber: deadalnix.

You should remove the whole peerid business, it doesn't seem relevant to the first iteration.

This revision now requires changes to proceed.Oct 1 2021, 13:38
Fabien abandoned this revision.Nov 21 2022, 19:10

Revision Contents
Changeset List

PathSize
src/
avalanche/
6 lines
2 lines
11 lines
43 lines
test/
6 lines
52 lines

Diff 30230

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...