Differential D10197

[avalanche] Accept conflicting proofs from p2p
AbandonedPublic
Actions

Authored by Fabien on Sep 24 2021, 13:35.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Summary

The current behavior is to ban the peer sending a conflicting proof. Since we don't know if the proof is valid or not until the conflict is solved, this is not desirable.

Ref T1854.

Depends on D10027.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_proof_voting

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_dont_ban_conflicting_proof

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16827
Build 33497: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 33496: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 24 2021, 13:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 24 2021, 13:35

Fabien requested review of this revision.Sep 24 2021, 13:35

Harbormaster completed remote builds in B16780: Diff 30159.Sep 24 2021, 13:51

PiRK accepted this revision.Sep 27 2021, 09:05

This revision is now accepted and ready to land.Sep 27 2021, 09:05

Rebase

Harbormaster completed remote builds in B16827: Diff 30231.Sep 30 2021, 13:06

Waiting for the processor features to be complete before an ultimate rebase

Fabien abandoned this revision.Feb 9 2022, 13:26

Revision Contents
Changeset List

Path

Size

src/

avalanche/

9 lines

peermanager.cpp

6 lines

net_processing.cpp

5 lines

test/

functional/

abc_p2p_avalanche_proof_voting.py

10 lines

test_framework/

10 lines

Diff 30231

src/avalanche/peermanager.h

Loading...

src/avalanche/peermanager.cpp

Loading...

src/net_processing.cpp

Loading...

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...

test/functional/test_framework/avatools.py

Loading...