Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC97c8ab66348b: [avalanche] Add a comparator for proof shared pointers

Summary

This will be useful for sorting proofs by score. Extracted from D10027.

Ref T1854.

Test Plan

ninja check-avalanche-proof_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_shared_proof_comparator

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16854
Build 33548: Build Diff	build-debug · build-diff · lint-circular-dependencies · build-without-wallet · build-clang · build-clang-tidy
Build 33547: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 30 2021, 08:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2021, 08:28

Fabien requested review of this revision.Sep 30 2021, 08:28

Harbormaster completed remote builds in B16821: Diff 30225.Sep 30 2021, 08:43

Fabien mentioned this in D10027: [avalanche] Add conflicting proofs to the vote.Sep 30 2021, 12:35

Fabien added a child revision: D10027: [avalanche] Add conflicting proofs to the vote.Sep 30 2021, 12:36

deadalnix requested changes to this revision.Sep 30 2021, 15:43

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/avalanche/proofcomparator.h
28 ↗	(On Diff #30225)	This calls for a ternary.
src/avalanche/test/proof_tests.cpp
655 ↗	(On Diff #30225)	Put it in its own test, no? That is this much less to recompile at once and it can run in parallel. If the header is different, then the test might as well be.

This revision now requires changes to proceed.Sep 30 2021, 15:43

Address feedback.
Note to reviewers: the test needs a TestingSetup fixture in order to initialize the coin db required when calling buildRandomProof().

Fix copyright year

Harbormaster completed remote builds in B16843: Diff 30250.Sep 30 2021, 19:47

Harbormaster completed remote builds in B16844: Diff 30251.Sep 30 2021, 19:50

Rebase

Harbormaster completed remote builds in B16854: Diff 30266.Oct 1 2021, 12:17

deadalnix accepted this revision.Oct 1 2021, 13:34

This revision is now accepted and ready to land.Oct 1 2021, 13:34

Closed by commit rABC97c8ab66348b: [avalanche] Add a comparator for proof shared pointers (authored by abc-bot, committed by Fabien). · Explain WhyOct 1 2021, 19:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC97c8ab66348b: [avalanche] Add a comparator for proof shared pointers.