Differential D10310

Remove the remove_reference_t business from VoteItemUpdate
ClosedPublic
Actions

Authored by deadalnix on Oct 12 2021, 12:23.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe5847bdfc287: Remove the remove_reference_t business from VoteItemUpdate

Summary

It is completely unecessary when a good old move does the same trick without putting strange constraint on the user.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16973
Build 33782: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 33781: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 12 2021, 12:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2021, 12:23

deadalnix requested review of this revision.Oct 12 2021, 12:23

Fabien accepted this revision.Oct 12 2021, 12:39

This revision is now accepted and ready to land.Oct 12 2021, 12:39

Harbormaster completed remote builds in B16973: Diff 30452.Oct 12 2021, 12:42

Closed by commit rABCe5847bdfc287: Remove the remove_reference_t business from VoteItemUpdate (authored by deadalnix). · Explain WhyOct 12 2021, 12:53

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCe5847bdfc287: Remove the remove_reference_t business from VoteItemUpdate.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.h

6 lines

Diff 30452

View Options

Remove the remove_reference_t business from VoteItemUpdateClosedPublicActions