Differential D10439

[avalanche] Make `isConflictingProofPreferred` a comparator
ClosedPublic
Actions

Authored by Fabien on Nov 8 2021, 08:09.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC5f0c2f9d3060: [avalanche] Make `isConflictingProofPreferred` a comparator

Summary

This was intended to be a peer manager static method, but it will eventually be used in the orphan proof pool as well, so let make it a proper comparator.

Ref T1854.

Supersedes D10404.
Depends on D10435.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_conflictingproofcomparator

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17199
Build 34229: Build Diff	lint-circular-dependencies · build-clang-tidy · build-without-wallet · build-debug · build-clang · build-diff
Build 34228: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 8 2021, 08:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 8 2021, 08:09

Fabien requested review of this revision.Nov 8 2021, 08:09

Harbormaster completed remote builds in B17199: Diff 30793.Nov 8 2021, 08:43

Rebase

Harbormaster completed remote builds in B17217: Diff 30822.Nov 10 2021, 10:00

Fabien added a child revision: D10459: [avalanche] Introduce the ProofPool class.Nov 10 2021, 23:30

deadalnix accepted this revision.Nov 17 2021, 17:39

This revision is now accepted and ready to land.Nov 17 2021, 17:39

Closed by commit rABC5f0c2f9d3060: [avalanche] Make `isConflictingProofPreferred` a comparator (authored by Fabien). · Explain WhyNov 18 2021, 08:35

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5f0c2f9d3060: [avalanche] Make `isConflictingProofPreferred` a comparator.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

3 lines

peermanager.cpp

31 lines

proofcomparator.h

39 lines

test/

peermanager_tests.cpp

8 lines

Diff 30793

src/avalanche/peermanager.h

Loading...

src/avalanche/peermanager.cpp

Loading...

src/avalanche/proofcomparator.h

Loading...

src/avalanche/test/peermanager_tests.cpp

Loading...