Remove unused `plTxnReplaced` parameter to AcceptToMemoryPool
ClosedPublic
Actions

Authored by schancel on Mar 6 2018, 05:10.

Details

Reviewers

deadalnix
jasonbcox
matiu

Group Reviewers

Restricted Project

Commits

rSTAGINGef4ee06f6d0f: Remove unused `plTxnReplaced` parameter to AcceptToMemoryPool
rABCef4ee06f6d0f: Remove unused `plTxnReplaced` parameter to AcceptToMemoryPool

Summary

See title

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

accept-unused1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2007
Build 2162: Bitcoin ABC Buildbot (legacy)
Build 2161: arc lint + arc unit

Event Timeline

schancel created this revision.Mar 6 2018, 05:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2018, 05:10

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

koalafire

Love the gifs in your comments. XD

This revision is now accepted and ready to land.Mar 6 2018, 05:34

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2007: Diff 3093.Mar 6 2018, 05:40

Closed by commit rABCef4ee06f6d0f: Remove unused `plTxnReplaced` parameter to AcceptToMemoryPool (authored by schancel). · Explain WhyMar 7 2018, 19:09

This revision was automatically updated to reflect the committed changes.

PiRK mentioned this in D10412: [net processing] Add doxygen comments for orphan data and function.Nov 2 2021, 10:33

PiRK mentioned this in rABCac7a1c69960f: [net processing] Add doxygen comments for orphan data and function.Nov 3 2021, 07:06

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

14 lines

rpc/

rawtransaction.cpp

2 lines

test/

txvalidationcache_tests.cpp

4 lines

validation.h

3 lines

validation.cpp

22 lines

wallet/

wallet.cpp

2 lines

Diff 3093

View Options

src/net_processing.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

Remove unused `plTxnReplaced` parameter to AcceptToMemoryPoolClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3093

src/net_processing.cpp

src/rpc/rawtransaction.cpp

src/test/txvalidationcache_tests.cpp

src/validation.h

src/validation.cpp

src/wallet/wallet.cpp

Remove unused `plTxnReplaced` parameter to AcceptToMemoryPool
ClosedPublic
Actions

Revision Contents
Changeset List