Page MenuHomePhabricator
Differential D10573

Run dumpwallet for legacy wallets only in wallet_backup.py
AbandonedPublic
Actions

Authored by PiRK on Nov 26 2021, 15:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Descriptor wallets don't support dumpwallet, so make the tests that do
dumpwallet legacy wallet only.

This is a backport of core#19077 [22/26]
https://github.com/bitcoin/bitcoin/pull/19077/commits/310b0fde04639b7446efd5c1d2701caa4b991b86

Depends on D10576

Test Plan

ninja check-functional

Diff Detail

Event Timeline

PiRK created this revision.Nov 26 2021, 15:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 15:55
PiRK requested review of this revision.Nov 26 2021, 15:55
teamcity edited the summary of this revision. (Show Details)Nov 26 2021, 15:55
PiRK added a child revision: D10574: Update wallet_multiwallet.py for descriptor and sqlite wallets.Nov 26 2021, 16:01
Harbormaster completed remote builds in B17410: Diff 31100.Nov 26 2021, 16:23
PiRK planned changes to this revision.Nov 30 2021, 17:47
PiRK updated this revision to Diff 31198.Dec 1 2021, 10:05

rebase

Harbormaster completed remote builds in B17481: Diff 31198.Dec 1 2021, 10:21
Fabien requested changes to this revision.Dec 3 2021, 20:19
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_runner.py
110

We should probably get theses tests to work with descriptors before we do the DB switch, so we are confident we have good covering

This revision now requires changes to proceed.Dec 3 2021, 20:19
PiRK added inline comments.Dec 4 2021, 18:59
test/functional/test_runner.py
110

I will have another look at it. The issue with these missing tests is to identify what causes a very small difference in fee calculation between legacy wallets and descriptor wallets. The fee calculation code in the node is hard to follow.

Ref D10220

PiRK added a comment.Dec 9 2021, 14:19

I'm also working on backporting core#18788, which add a lot of functional test coverage for descriptor wallets.

PiRK updated this revision to Diff 31431.Dec 15 2021, 16:56

rebase after reordering the stack (D10576 moved before the sqlite format is used)

Harbormaster completed remote builds in B17655: Diff 31431.Dec 15 2021, 17:13
Fabien accepted this revision.Dec 20 2021, 08:40
This revision is now accepted and ready to land.Dec 20 2021, 08:40
Fabien requested changes to this revision.Dec 20 2021, 08:50

This should be before https://reviews.bitcoinabc.org/D10568

This revision now requires changes to proceed.Dec 20 2021, 08:50
PiRK removed a parent revision: D10572: doc: Update wallet files in files.md.Dec 20 2021, 14:35
PiRK updated this revision to Diff 31473.Dec 20 2021, 14:36
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D10576: rpc, wallet: Expose database format in getwalletinfo.

move before sqlite activation for descriptor wallets (D10568)

PiRK added a child revision: D10568: Use SQLite for descriptor wallets.Dec 20 2021, 14:39
Harbormaster completed remote builds in B17685: Diff 31473.Dec 20 2021, 14:51
PiRK removed a child revision: D10574: Update wallet_multiwallet.py for descriptor and sqlite wallets.Dec 20 2021, 17:14
PiRK abandoned this revision.Dec 20 2021, 17:18

Clearing my queue

PiRK mentioned this in D10752: BasicTestingSetup: Add ArgsManager..Jan 4 2022, 07:47

Revision Contents
Changeset List

PathSize
test/
functional/
1 line
77 lines

Diff 31198

View Options

test/functional/test_runner.py

Loading...
View Options

test/functional/wallet_backup.py

Loading...