Page MenuHomePhabricator

Run dumpwallet for legacy wallets only in wallet_backup.py
AbandonedPublic

Authored by PiRK on Nov 26 2021, 15:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Descriptor wallets don't support dumpwallet, so make the tests that do
dumpwallet legacy wallet only.

This is a backport of core#19077 [22/26]
https://github.com/bitcoin/bitcoin/pull/19077/commits/310b0fde04639b7446efd5c1d2701caa4b991b86

Depends on D10576

Test Plan

ninja check-functional

Event Timeline

PiRK requested review of this revision.Nov 26 2021, 15:55
PiRK planned changes to this revision.Nov 30 2021, 17:47
Fabien requested changes to this revision.Dec 3 2021, 20:19
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_runner.py
110

We should probably get theses tests to work with descriptors before we do the DB switch, so we are confident we have good covering

This revision now requires changes to proceed.Dec 3 2021, 20:19
test/functional/test_runner.py
110

I will have another look at it. The issue with these missing tests is to identify what causes a very small difference in fee calculation between legacy wallets and descriptor wallets. The fee calculation code in the node is hard to follow.

Ref D10220

I'm also working on backporting core#18788, which add a lot of functional test coverage for descriptor wallets.

rebase after reordering the stack (D10576 moved before the sqlite format is used)

This revision is now accepted and ready to land.Dec 20 2021, 08:40
This revision now requires changes to proceed.Dec 20 2021, 08:50
PiRK edited the summary of this revision. (Show Details)

move before sqlite activation for descriptor wallets (D10568)