Differential D1189

Refactor SigHashType and its test.
ClosedPublic
Actions

Authored by deadalnix on Mar 12 2018, 15:14.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Maniphest Tasks

T301: Automatic Future Hardfork Replay Protection

Commits

rSTAGING8a6525495c6e: Refactor SigHashType and its test.
rABC8a6525495c6e: Refactor SigHashType and its test.

Summary

This makes part of the code simpler and the test more exaustive.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sighashtypedefault

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2055
Build 2257: Bitcoin ABC Buildbot (legacy)
Build 2256: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 12 2018, 15:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 12 2018, 15:14

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2048: Diff 3152.Mar 12 2018, 15:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix added a child revision: D1190: Add support for having different forkid values in SigHashType.Mar 12 2018, 16:56

rebase

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2055: Diff 3160.Mar 12 2018, 20:40

Looks good.

This revision is now accepted and ready to land.Mar 13 2018, 03:52

Closed by commit rABC8a6525495c6e: Refactor SigHashType and its test. (authored by deadalnix). · Explain WhyMar 13 2018, 13:15

This revision was automatically updated to reflect the committed changes.

schancel added a task: T301: Automatic Future Hardfork Replay Protection.Mar 15 2018, 14:50

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

4 lines

rpc/

rawtransaction.cpp

4 lines

script/

interpreter.cpp

25 lines

sighashtype.h

18 lines

test/

multisig_tests.cpp

2 lines

script_P2SH_tests.cpp

10 lines

script_sighashtype_tests.cpp

233 lines

script_tests.cpp

15 lines

transaction_tests.cpp

4 lines

txvalidationcache_tests.cpp

12 lines

wallet/

wallet.cpp

2 lines

Diff 3160

View Options

src/bitcoin-tx.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/script/interpreter.cpp

View Options

src/script/sighashtype.h

View Options

src/test/multisig_tests.cpp

View Options

src/test/script_P2SH_tests.cpp

View Options

src/test/script_sighashtype_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/transaction_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

Refactor SigHashType and its test.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3160

src/bitcoin-tx.cpp

src/rpc/rawtransaction.cpp

src/script/interpreter.cpp

src/script/sighashtype.h

src/test/multisig_tests.cpp

src/test/script_P2SH_tests.cpp

src/test/script_sighashtype_tests.cpp

src/test/script_tests.cpp

src/test/transaction_tests.cpp

src/test/txvalidationcache_tests.cpp

src/wallet/wallet.cpp

Refactor SigHashType and its test.
ClosedPublic
Actions

Revision Contents
Changeset List