This will allow to enable replay protection at any point in time.
- Group Reviewers
- Maniphest Tasks
- T301: Automatic Future Hardfork Replay Protection
- rSTAGING306b4f9c13ca: Implement a flag to trigger replay protection when passed down to SignatureHash
rABC306b4f9c13ca: Implement a flag to trigger replay protection when passed down to SignatureHash
|1354 ↗||(On Diff #3158)|
Add a comment explaining the intention here. It looks like it's intended to scramble values greater than 1-byte in size, but I'm not sure.
|149 ↗||(On Diff #3158)|
Shouldn't this one be shold? Seems backwards looking at the function name.
|151 ↗||(On Diff #3158)|
If you don't want to name the above variable shold, then maybe call this one shnoReplay to make it clearer?