Page MenuHomePhabricator
Differential D3671

Merge #10777: [tests] Avoid redundant assignments. Remove unused variables
ClosedPublic
Actions

Authored by nakihito on Jul 12 2019, 18:42.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING5e110a02f6cb: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables
rABC5e110a02f6cb: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables
Summary

49eb0916d [tests] Avoid redundant assignments. Remove unused variables. (practicalswift)

Pull request description:

  • Remove unused variables.
  • Avoid redundant assignments.

Tree-SHA512: 74dd59680c785c601982a791648bc5d9b04e2b4509119e05f2e402b94998f5bbcbdea1f82d05e5f431fe06642e8db7c346fa8bc4c11f8cdcc554bc70d735534c

Backport of Core PR10777
https://github.com/bitcoin/bitcoin/pull/10777/

Test Plan
make check
test_runnery.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 12 2019, 18:42
Owners added a reviewer: Restricted Owners Package.Jul 12 2019, 18:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 18:42
nakihito planned changes to this revision.Jul 12 2019, 18:42
teamcity added a comment.Jul 12 2019, 18:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B6845: Diff 10272!Jul 12 2019, 18:43
teamcity added a comment.Jul 12 2019, 18:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Jul 15 2019, 17:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6845: Diff 10272.Jul 15 2019, 17:15
teamcity added a comment.Jul 15 2019, 17:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

nakihito requested review of this revision.Jul 15 2019, 17:17
jasonbcox requested changes to this revision.Jul 15 2019, 22:18

What's up with sighash_tests.cpp?

This revision now requires changes to proceed.Jul 15 2019, 22:18
nakihito added a comment.Jul 15 2019, 22:28
In D3671#86664, @jasonbcox wrote:

What's up with sighash_tests.cpp?

Ours was changed here: https://reviews.bitcoinabc.org/D1192#change-7XQqS0FPXW4M
It makes the PR's changes to this file irrelevant.

nakihito requested review of this revision.Jul 22 2019, 17:51
jasonbcox accepted this revision.Jul 23 2019, 01:21
This revision is now accepted and ready to land.Jul 23 2019, 01:21
Closed by commit rABC5e110a02f6cb: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyJul 23 2019, 17:19
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC5e110a02f6cb: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING5e110a02f6cb: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables.Sep 19 2019, 01:23

Revision Contents
Changeset List

PathSize
src/
test/
6 lines

Diff 10407

View Options

src/test/scriptnum_tests.cpp

Loading...