Page MenuHomePhabricator

Merge #10777: [tests] Avoid redundant assignments. Remove unused variables
ClosedPublic

Authored by nakihito on Jul 12 2019, 18:42.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC5e110a02f6cb: Merge #10777: [tests] Avoid redundant assignments. Remove unused variables
Summary

49eb0916d [tests] Avoid redundant assignments. Remove unused variables. (practicalswift)

Pull request description:

  • Remove unused variables.
  • Avoid redundant assignments.

Tree-SHA512: 74dd59680c785c601982a791648bc5d9b04e2b4509119e05f2e402b94998f5bbcbdea1f82d05e5f431fe06642e8db7c346fa8bc4c11f8cdcc554bc70d735534c

Backport of Core PR10777
https://github.com/bitcoin/bitcoin/pull/10777/

Test Plan
make check
test_runnery.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10777
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6845
Build 11737: Bitcoin ABC Teamcity Staging
Build 11736: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 12 2019, 18:42
Owners added a reviewer: Restricted Owners Package.Jul 12 2019, 18:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 18:42
nakihito planned changes to this revision.Jul 12 2019, 18:42
nakihito requested review of this revision.Jul 15 2019, 17:17
jasonbcox requested changes to this revision.Jul 15 2019, 22:18

What's up with sighash_tests.cpp?

This revision now requires changes to proceed.Jul 15 2019, 22:18

What's up with sighash_tests.cpp?

Ours was changed here: https://reviews.bitcoinabc.org/D1192#change-7XQqS0FPXW4M
It makes the PR's changes to this file irrelevant.

nakihito requested review of this revision.Jul 22 2019, 17:51
jasonbcox accepted this revision.Jul 23 2019, 01:21
This revision is now accepted and ready to land.Jul 23 2019, 01:21