Page MenuHomePhabricator
Differential D10756

Change GetBlocksDir() to ArgsManager.GetBlocksDirPath().
ClosedPublic
Actions

Authored by PiRK on Jan 3 2022, 16:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC94db4facf3f2: Change GetBlocksDir() to ArgsManager.GetBlocksDirPath().
Summary

This is a backport of core#21244 [7/8]
https://github.com/bitcoin/bitcoin/pull/21244/commits/b4190eff72c00e384ad238f9c2f10c8b91be969b

Note: The few minor difference from Core are explained by D4495 (Range-based for loop) and D7579 (blockdb.cpp)

Depends on D10755

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Jan 3 2022, 16:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2022, 16:32
PiRK requested review of this revision.Jan 3 2022, 16:32
PiRK edited the summary of this revision. (Show Details)Jan 3 2022, 16:34
PiRK added a parent revision: D10755: scripted-diff: Modify unit tests to use the ArgsManager in the BasicTestingSetup class instead of implicitly relying on gArgs.
PiRK added a child revision: D10757: Change ClearDataDirPathCache() to ArgsManager.ClearPathCache()..Jan 3 2022, 16:34
teamcity edited the summary of this revision. (Show Details)Jan 3 2022, 16:35
Harbormaster completed remote builds in B17780: Diff 31613.Jan 3 2022, 17:24
Fabien accepted this revision.Jan 3 2022, 20:55
This revision is now accepted and ready to land.Jan 3 2022, 20:55
PiRK removed a parent revision: D10753: scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp.Jan 4 2022, 07:50
Closed by commit rABC94db4facf3f2: Change GetBlocksDir() to ArgsManager.GetBlocksDirPath(). (authored by Kiminuo <kiminuo@protonmail.com>, committed by PiRK). · Explain WhyJan 4 2022, 14:32
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC94db4facf3f2: Change GetBlocksDir() to ArgsManager.GetBlocksDirPath()..

Revision Contents
Changeset List

PathSize
src/
4 lines
11 lines
qt/
2 lines
util/
10 lines
59 lines
2 lines

Diff 31613

View Options

src/blockdb.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/validation.cpp

Loading...